datetime.datetime.utcnow() is deprecated, replace with a central utility
#658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrieg123
requested review from
AdamGlustein,
alexddobkin,
robambalu and
svatasoiu
as code owners
wrieg123
commented
Dec 24, 2025
| del runner | ||
| self.assertTrue(output.get("stop")) | ||
| self.assertLess(output["stop"], endtime) | ||
| self.assertLess(output["stop"], endtime.replace(tzinfo=None)) |
Collaborator
Author
There was a problem hiding this comment.
this is a tz-aware comparison, removes the tz from the endtime
wrieg123
commented
Dec 24, 2025
| self.assertFalse(runner.is_alive()) | ||
| self.assertTrue(output.get("stop")) | ||
| self.assertLess(output["stop"], endtime) | ||
| self.assertLess(output["stop"], endtime.replace(tzinfo=None)) |
Collaborator
Author
There was a problem hiding this comment.
this is a tzaware comparison, removes tzinfo for comparison
wrieg123
added
type: enhancement
robambalu
reviewed
Dec 24, 2025
csp/utils/datetime.py
Outdated
|
|
||
|
|
||
| def utc_now() -> datetime: | ||
| return datetime.now(timezone.utc) |
Collaborator
There was a problem hiding this comment.
we should add replace(tzinfo=None) here so its consistent with current utcnow() calls and potential csp expectations
Signed-off-by: Will Rieger <will.r.rieger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.datetime.utcnow()is deprecated and creates lots of warnings in tests, addedutc_now()tocsp.utils.datetime