added Avro support for KafkaAdapter #645
Conversation
mildek
requested review from
AdamGlustein,
alexddobkin,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
b76ceb9 to
e3ea18f
Compare
…rotocol Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
1238242 to
8ce67ec
Compare
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
2 times, most recently
from
61090fb to
e6af9f8
Compare
Signed-off-by: Krzysztof Milde <Krzysztof.Milde@Point72.com>
mildek
force-pushed
the
feat/add-kafka-avro-protocol
branch
from
e6af9f8 to
aa8a87b
Compare
| - nodefaults | ||
| dependencies: | ||
| - astor | ||
| - avrocpp |
There was a problem hiding this comment.
we shouldnt have platform-specific behavior, this should work on windows/mac as well
There was a problem hiding this comment.
From what i can see, this is currently building on 1 out of 6 platform combinations:
- Linux/No Conda
- Linux/Conda
- Mac/No Conda
- Mac/Conda
- Windows/No Conda
- Windows/Conda
There was a problem hiding this comment.
avrocpp is not available on mac with arm cpus
There was a problem hiding this comment.
ok so lets make it available on mac with arm cpus
There was a problem hiding this comment.
ive kicked this off upstream, shouldnt take too long. win64 is already available so that should be easy as well.
| else() | ||
| find_package(RdKafka REQUIRED) | ||
| find_package(Avro QUIET) | ||
| if(Avro_FOUND) |
There was a problem hiding this comment.
this results in silent skipping, we don't do anything this way currently.
if something is expected to be built (via an option in the top level CMakeLists), it is required to be found. I would expect that we want something similar for this.
No description provided.