fix: add defensive optional chaining for remaining .info.time.created accesses#5
Open
Milofax wants to merge 1 commit intoPlutarch01:masterfrom
Open
fix: add defensive optional chaining for remaining .info.time.created accesses#5Milofax wants to merge 1 commit intoPlutarch01:masterfrom
Milofax wants to merge 1 commit intoPlutarch01:masterfrom
Conversation
All 13 remaining occurrences of `.info.time.created` across store.ts,
store-artifacts.ts, and store-search.ts crash with TypeError when a
message has malformed or missing `info.time` metadata.
v0.13.2 introduced `getValidMessageInfo()` and
`filterValidConversationMessages()` to guard upstream entry points,
but 13 downstream access sites still use bare property chains.
Replace every bare `.info.time.created` access with
`.info?.time?.created ?? 0` so a single malformed message cannot
crash the entire plugin.
Reproducer: any session containing a message where `info.time` is
undefined triggers:
TypeError: undefined is not an object
(evaluating 'archivedMessages.at(-1)?.info.time.created')
at ensureSummaryGraphSync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?.optional chaining +?? 0fallback to all 13 remaining occurrences of.info.time.createdacrossstore.ts,store-artifacts.ts, andstore-search.tsTypeError: undefined is not an objectcrash inensureSummaryGraphSyncand related code paths when messages have malformed or missinginfo.timemetadataProblem
v0.13.2 introduced
getValidMessageInfo()andfilterValidConversationMessages()to guard upstream entry points (#4), but 13 downstream access sites still use bare property chains and crash when a malformed message slips through:Changes
src/store.tsdiagnoseSummarySession,shouldSyncDerived×3,buildArchivedSignature,ensureSummaryGraphSync×2src/store-artifacts.tsexternalizeMessage×2,writeStoredSessionsrc/store-search.tssearchSync,rebuildSessionFtsRowsSync,replaceMessageSearchRowSyncVerification
npm run typecheck✅npm run lint✅npm run build✅npm test— 168/168 pass ✅.info.time.createdpatterns in source