fix memory leak and overflow issues #5
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found and fixed a few critical bugs while reviewing the code:
memory leak in search
the case-insensitive search was corrupting the original text buffer by calling
CharLowerBuffWdirectly on it. now we create a separate copy for comparison, keeping the original safe.overflow protection in replace all
when replacing text in large files, the buffer size calculation could overflow. added a check to prevent crashes when the result would be too large.
better default filename
changed the save dialog default from
*.txt(which is a wildcard) toUntitled.txt-which makes more sense-.tested all fixes with msvc, no warnings or issues found