Mendsley/snapshot labels #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendsley
force-pushed
the
mendsley/snapshot_labels
branch
30 times, most recently
from
7ccb91c to
a8db7db
Compare
mendsley
force-pushed
the
mendsley/snapshot_labels
branch
8 times, most recently
from
cc47a15 to
aff966a
Compare
This is primarily motivated by the desire to create windows containers with a rootfs size larger than the snapshotter default. This can be acheived with the `ctr run` command with the `--snapshotter-label` argument. The snapshotter filters labels for which it has an interest and ignores others, so this change simply forwards all supplied labels instead of making an API change. For the two cases below the commands run are: 1. `docker run --rm -it mcr.microsoft.com/windows/servercore:ltsc2022 powershell -Command "(gdr C).Free + (gdr C).Used"` 2. `docker run --label "containerd.io/snapshot/windows/rootfs.sizebytes=32212254720" --rm -it mcr.microsoft.com/windows/servercore:ltsc2022 powershell -Command "(gdr C).Free + (gdr C).Used"` Before this change: ------------------- Output from 1: `21339549696` Output from 2: `21339549696` After this change: ------------------ Output from 1: `21339549696` Output from 2: `32076963840`
mendsley
force-pushed
the
mendsley/snapshot_labels
branch
from
aff966a to
caa5f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.