Skip to content

Fix local network permission dialogue appearance [APP-211] [PLAN-530]#8

Merged
jegora merged 3 commits intomasterfrom
hq/jegor/APP-211/PLAN-530_local-network-permission-popup
Oct 17, 2024
Merged

Fix local network permission dialogue appearance [APP-211] [PLAN-530]#8
jegora merged 3 commits intomasterfrom
hq/jegor/APP-211/PLAN-530_local-network-permission-popup

Conversation

@jegora
Copy link
Collaborator

@jegora jegora commented Oct 17, 2024

What was changed?

  • Trigger iOS system dialog when user requests for local permission for the first time
  • Ignore LocalNetworkPrivacy.checkAccessState result for the first time
  • Remove unnecessary logic from LocalNetworkPrivacy file

Checklist:

Screenshots and Videos

Video #1: shows how local network permission handled on denial

RPReplay_Final1729153185.mov

Video #2: shows that custom local network popup doesn't appear after some seconds after system dialogue

RPReplay_Final1729153448.mov

Related

…sion request

hq/jegor/APP-211/PLAN-530_local-network-permission-popup
hq/jegor/APP-211/PLAN-530_local-network-permission-popup
…on-popup

Ticket: hq/jegor/APP-211/PLAN-530_local-network-permission-popup
Signed-off-by: jegor <j.alexeichuck@hqsoftwarelab.com>
@jegora jegora self-assigned this Oct 17, 2024
@jegora jegora marked this pull request as ready for review October 17, 2024 10:25
@jegora jegora merged commit f695673 into master Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants