Skip to content

Fix boolean on database dump #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamshory merged 1 commit into from
Jan 14, 2026
Merged

Fix boolean on database dump #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/Generator/PicoDatabaseDump.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,12 @@ public function dumpDataFromSchema($entity, $databaseType, $batchSize = 100)
{
// Check if the target database is PostgreSQL
$isPgSql = $databaseType == PicoDatabaseType::DATABASE_TYPE_PGSQL || $databaseType == PicoDatabaseType::DATABASE_TYPE_POSTGRESQL;

// Check if the target database is SQLite
$isSqlite = $databaseType == PicoDatabaseType::DATABASE_TYPE_SQLITE;

// Check if the target database is SQL Server
$isSqlServer = $databaseType == PicoDatabaseType::DATABASE_TYPE_SQLSERVER;

$tableName = $entity['name'];

Expand Down Expand Up @@ -208,7 +214,7 @@ public function dumpDataFromSchema($entity, $databaseType, $batchSize = 100)

$rows = array();
foreach ($filteredBatch as $data) {
$rows[] = "(" . implode(", ", $this->fixData($data, $columnInfo, $isPgSql)) . ")";
$rows[] = "(" . implode(", ", $this->fixData($data, $columnInfo, $isPgSql, $isSqlite, $isSqlServer)) . ")";
}

$allSql .= implode("\r\n", $sqlInsert)
Expand Down Expand Up @@ -250,9 +256,11 @@ private function prepareColumnInfo($entity)
* @param array $data Associative array of column => value.
* @param array $columnInfo Metadata for each column.
* @param bool $isPgSql Whether the target database is PostgreSQL.
* @param bool $isSqlite Whether the target database is SQLite.
* @param bool $isSqlServer Whether the target database is SQL Server.
* @return array The formatted data array.
*/
public function fixData($data, $columnInfo, $isPgSql)
public function fixData($data, $columnInfo, $isPgSql, $isSqlite, $isSqlServer)
{
foreach ($data as $key => $value) {
if ($value === null) {
Expand All @@ -261,9 +269,23 @@ public function fixData($data, $columnInfo, $isPgSql)
} else if (isset($columnInfo[$key]) && in_array($columnInfo[$key]->normalizedType, ['integer', 'float'])) {
// Keep numeric values as they are (no quotes)
$data[$key] = $value;
} else if (isset($columnInfo[$key]) && in_array($columnInfo[$key]->normalizedType, ['boolean', 'bool']) && $isPgSql) {
// Handle PostgreSQL boolean conversion
$data[$key] = $this->toBoolean($value) ? 'true' : 'false';
} else if (isset($columnInfo[$key]) && in_array($columnInfo[$key]->normalizedType, ['boolean', 'bool'])) {
// Handle boolean values
if($isPgSql)
{
// Force to boolean
$data[$key] = $this->toBoolean($value) ? 'true' : 'false';
}
else if($isSqlite || $isSqlServer)
{
// Force to integer
$data[$key] = $this->toBoolean($value) ? '1' : '0';
}
else
{
// MySQL and MariaDB
$data[$key] = $this->toBoolean($value) ? 'true' : 'false';
}
} else {
// Treat as string: escape single quotes and wrap in quotes
$data[$key] = "'" . str_replace("'", "''", $value) . "'";
Expand Down