-
-
Notifications
You must be signed in to change notification settings - Fork 296
various fixes for scroll wheel #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
*fix using scroll delta instead axis code *fix lost registering low res axis if it will be used *fix duplicate inverting direction of delta *make scroll behavior more responsive *fix and imprv logging
|
Seems to have fixed the issue where my MX Master 3's scroll wheel would suddenly become unresponsive. Thank you. |
| if (!_input_axis.has_value()) | ||
| return; | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these blank new lines for? 🤔
Here, and in lines 96, 135, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The God told me put this line here 🤣. Actually i don't have a plan to make stylish fixes after 3 years
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyway without this PR wheel scrolling logic of logiops still is broken and do not work correct
| if (lowres_movement == 0) { | ||
| lowres_movement = hires_remainder > 0 ? 1 : -1; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code style changes like these introduce unnecessary noise in the diff. I'd recommend removing them and keeping the diff focused on the actual behavior changes.
|
@PixlOne some reasons to merge this PR Detailed Changes in PR #413This PR modifies 2 files in the 1.
|
| Fix | Issue | Solution |
|---|---|---|
| 1 | Wrong value passed to getLowResAxis() |
Use _input_axis.value() instead of axis |
| 2 | Low-res axis not registered | New registerAxis() method registers both axes |
| 3 | Direction inverted twice | Removed redundant inversion |
| 4 | Scroll feels laggy | Lowered threshold from 60 to 1 |
| 5 | Wrong-direction events | Added direction validation check |
| 6 | Poor debugging info | Added comprehensive logging |
*fix using scroll delta instead axis code
*fix lost registering low res axis if it will be used *fix duplicate inverting direction of delta
*make scroll behavior more responsive
*fix and imprv logging