Skip to content

✨ (Sonar) Fixed finding: "Change this code to not construct SQL queries directly from user-controlled data." #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixee-demo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ (Sonar) Fixed finding: "Change this code to not construct SQL queries directly from user-controlled data." #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/main/java/org/owasp/webgoat/lessons/sqlinjection/advanced/SqlInjectionChallenge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
import org.springframework.web.bind.annotation.RestController;

/**
* @author nbaars
* @since 4/8/17.
* author nbaars
* since 4/8/17.
*/
@RestController
@AssignmentHints(
Expand Down Expand Up @@ -64,9 +64,10 @@ public AttackResult registerNewUser(

try (Connection connection = dataSource.getConnection()) {
String checkUserQuery =
"select userid from sql_challenge_users where userid = '" + username_reg + "'";
Statement statement = connection.createStatement();
ResultSet resultSet = statement.executeQuery(checkUserQuery);
"select userid from sql_challenge_users where userid = ?";
PreparedStatement statement = connection.prepareStatement(checkUserQuery);
statement.setString(1, username_reg);
ResultSet resultSet = statement.executeQuery();

if (resultSet.next()) {
if (username_reg.contains("tom'")) {
Expand Down