Removed dependencies in certain document-related classes#2073
Open
Lehonti wants to merge 5 commits intoPintaProject:masterfrom
Open
Removed dependencies in certain document-related classes#2073Lehonti wants to merge 5 commits intoPintaProject:masterfrom
Lehonti wants to merge 5 commits intoPintaProject:masterfrom
Conversation
Member
|
There are likely going to be some merge conflicts from the DocumentWorkspace changes in #2046 so I'll wait to review this PR until that one lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the removed dependencies are passed as arguments to methods.
This comes at the cost of introducing references to
PintaCorein several places, which does not re-introduce them where they were before (which would trash our previous work): the dependencies are being obtained and coordinated at a more 'outer' layer of the code.Notice that some of the places where the
PintaCorereferences were introduced are tools (as inTextTool,PencilTool, ...). I can envision that being refactored so that the tools use services instead ofPintaCorereferences.The original goal was removing all dependencies (other than
Document) fromDocumentWorkspace, but it got quite large.