[PC-000] 퍼즐 부족 다이얼로그 표출되자마자 꺼지는 이슈 수정

[comst19]

1. ⭐️ 변경된 내용

• 퍼즐 사용 api에 .also로 다이얼로그 끄는 로직 제거

2. 🖼️ 스크린샷(선택)

3. 💡 알게된 부분

4. 📌 이 부분은 꼭 봐주세요!

Summary by CodeRabbit

• Refactor
  • Simplified navigation event handling by removing automatic dialog state cleanup that followed certain route transitions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request removes finalizer state updates (isShowDialog = false) that were triggered after navigation to MatchingDetailRoute and ContactRoute in MatchingViewModel, while preserving the existing error handling logic with onFailure { handleMatchingError(it) }.

Changes

Cohort / File(s)	Summary
Dialog state cleanup removal feature/matching/src/main/java/com/puzzle/matching/graph/main/MatchingViewModel.kt	Removed .also { setState { copy(isShowDialog = false) } } finalizer blocks following two navigation calls, eliminating the automatic dialog state reset after navigating to MatchingDetailRoute and ContactRoute

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• [PC-1507] MatchingScreen 에서 발생하는 에러 예외 처리 #187: Modifies MatchingViewModel's error-handling and post-navigation state changes related to isShowDialog behavior.

Poem

🐰 A dialog state bid adieu,
No more false resets in view,
Navigation flows cleaner and light,
One less .also block in sight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fixing a bug where a puzzle shortage dialog closes immediately after appearing.
Description check	✅ Passed	The description follows the required template structure with the main change explained in section 1, though sections 2-4 are mostly empty or minimal.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/PC-000_fix_dialog

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

feature/matching/src/main/java/com/puzzle/matching/graph/main/MatchingViewModel.kt (1)

235-267: Optional: Consider explicit dialog state cleanup on success.

While the current fix correctly addresses the bug, isShowDialog remains true after successful navigation. Although this doesn't cause visible issues (since navigation occurs), you could optionally add explicit cleanup in the onSuccess blocks for cleaner state management:

}.onSuccess {
    // ... existing code ...
    setState { copy(isShowDialog = false) }
}.onFailure { handleMatchingError(it) }

This is a minor refinement and can be deferred if preferred.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5e4a42 and 1234a8a.

📒 Files selected for processing (1)

• feature/matching/src/main/java/com/puzzle/matching/graph/main/MatchingViewModel.kt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (2)

feature/matching/src/main/java/com/puzzle/matching/graph/main/MatchingViewModel.kt (2)

235-247: LGTM! Dialog state fix is correct.

Removing the .also { setState { copy(isShowDialog = false) } } block correctly fixes the issue where the puzzle shortage dialog was closing immediately. Previously, when the API failed with NOT_ENOUGH_PUZZLE, handleMatchingError would show the dialog, but the .also block would execute afterward and close it immediately.

---

256-267: LGTM! Consistent fix applied.

The same fix is correctly applied here—removing the .also block prevents the dialog from being closed immediately after handleMatchingError shows it on failure. The error handling logic is preserved correctly.