Skip to content

changes needed for v1_devtools #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
burdettadam wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

changes needed for v1_devtools #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/devtools-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
checkForBootstrapped = function(justNeedsBootstrap, needsBootstrapRuleset) {
return wrangler.bootstrapCheck(function(json) {
console.log(json);
if ($.inArray('b507199x14.prod', json.rids) > -1 && $.inArray('v1_wrangler.prod', json.rids) > -1) {
if ($.inArray('v1_devtools.prod', json.rids) > -1 && $.inArray('v1_wrangler.prod', json.rids) > -1) {
console.log("Pico is bootstrapped");
cb();
}
Expand Down
12 changes: 6 additions & 6 deletions ruleSets/bootstrap_prod.krl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ruleset DevTools_bootstrap {
"core": [
"a169x676.prod", // PDS
"a16x129.prod", // SendGrid module
"b507199x14.prod", //DevTools
"v1_devtools.prod", //DevTools
"v1_wrangler.prod", //wrangler
"b16x29.prod" // logging
],
Expand Down Expand Up @@ -73,16 +73,16 @@ ruleset DevTools_bootstrap {

bootstrapped = installed_rids{"rids"}
.klog(">>>> pico installed_rids before filter >>>> ")
.filter(function(v){v eq "b507199x14.prod"|| v eq "v1_wrangler.prod" })
.filter(function(v){v eq "v1_devtools.prod"|| v eq "v1_wrangler.prod" })
.klog(">>>> pico installed_rids after filter >>>> ")
.length()
.klog(">>>> pico installed_rids length >>>> ")
;// check if installed_rids includes b507199x14.prod --- use a filter and check if length is > 0.
;// check if installed_rids includes v1_devtools.prod --- use a filter and check if length is > 0.

}
if (bootstrapped >= 2 ) then// we have both devtools and wrangler
{
send_directive("found_b507199x14.prod_&_v1_wrangler.prod_for_developer")
send_directive("found_v1_devtools.prod_&_v1_wrangler.prod_for_developer")
with eci = eci;
}
fired {
Expand All @@ -92,8 +92,8 @@ ruleset DevTools_bootstrap {
log ">>>> pico needs a bootstrap >>>> ";
log ">>>> pico installed_rids, saw : " + rids.encode();
log ">>>> pico installed_rids, saw : " + rids_string;
log ">>>> pico installed_rids.filter(function(k,v){v eq b507199x14.prod}), saw : " + installed_rids.filter(function(k,v){v eq "b507199x14.prod"}).encode();
log ">>>> pico installed_rids.filter(function(k,v){v eq b507199x14.prod}).length();, saw : " + installed_rids.filter(function(k,v){v eq "b507199x14.prod"}).length();
log ">>>> pico installed_rids.filter(function(k,v){v eq v1_devtools.prod}), saw : " + installed_rids.filter(function(k,v){v eq "v1_devtools.prod"}).encode();
log ">>>> pico installed_rids.filter(function(k,v){v eq v1_devtools.prod}).length();, saw : " + installed_rids.filter(function(k,v){v eq "v1_devtools.prod"}).length();
raise explicit event devtools_bootstrap_needed ; // don't bootstrap everything? // we can bootstrap everythinb because you cant install the same ruleset twice.

}
Expand Down
4 changes: 2 additions & 2 deletions ruleSets/devtools_prod.krl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//b507199x14
//Flush the ruleset webpage: http://cs.kobj.net/ruleset/flush/b507199x14.prod;b507199x14.dev
//v1_devtools
//Flush the ruleset webpage: http://cs.kobj.net/ruleset/flush/v1_devtools.prod;v1_devtools.dev
ruleset devtools {
meta {
name "DevTools"
Expand Down