Skip to content

Standard usage of signum is <, >, ==. Not direct comparison with -1, 0, 1 #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henri-tremblay wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Standard usage of signum is <, >, ==. Not direct comparison with -1, 0, 1 #1887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/BigDecimalRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,13 @@ boolean before(BigDecimal value) {
return Refaster.anyOf(
value.compareTo(BigDecimal.ZERO) > 0,
BigDecimal.ZERO.compareTo(value) < 0,
value.signum() > 0,
value.signum() >= 1);
}

@AfterTemplate
@AlsoNegation
boolean after(BigDecimal value) {
return value.signum() == 1;
return value.signum() > 0;
}
}

Expand All @@ -114,14 +113,13 @@ boolean before(BigDecimal value) {
return Refaster.anyOf(
value.compareTo(BigDecimal.ZERO) < 0,
BigDecimal.ZERO.compareTo(value) > 0,
value.signum() < 0,
value.signum() <= -1);
}

@AfterTemplate
@AlsoNegation
boolean after(BigDecimal value) {
return value.signum() == -1;
return value.signum() < 0;
Copy link
Contributor

@timtebeek timtebeek Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll likely want to make the matching changes to this expected output file:

error-prone-support/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/BigDecimalRulesTestOutput.java

Lines 32 to 54 in 62077da

ImmutableSet<Boolean> testBigDecimalSignumIsPositive() {
return ImmutableSet.of(
BigDecimal.valueOf(1).signum() == 1,
BigDecimal.valueOf(2).signum() == 1,
BigDecimal.valueOf(3).signum() == 1,
BigDecimal.valueOf(4).signum() == 1,
BigDecimal.valueOf(5).signum() != 1,
BigDecimal.valueOf(6).signum() != 1,
BigDecimal.valueOf(7).signum() != 1,
BigDecimal.valueOf(8).signum() != 1);
}
ImmutableSet<Boolean> testBigDecimalSignumIsNegative() {
return ImmutableSet.of(
BigDecimal.valueOf(1).signum() == -1,
BigDecimal.valueOf(2).signum() == -1,
BigDecimal.valueOf(3).signum() == -1,
BigDecimal.valueOf(4).signum() == -1,
BigDecimal.valueOf(5).signum() != -1,
BigDecimal.valueOf(6).signum() != -1,
BigDecimal.valueOf(7).signum() != -1,
BigDecimal.valueOf(8).signum() != -1);
}

}
}
}
32 changes: 16 additions & 16 deletions ...ib/src/test/resources/tech/picnic/errorprone/refasterrules/BigDecimalRulesTestOutput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,25 @@ ImmutableSet<Boolean> testBigDecimalSignumIsZero() {

ImmutableSet<Boolean> testBigDecimalSignumIsPositive() {
return ImmutableSet.of(
BigDecimal.valueOf(1).signum() == 1,
BigDecimal.valueOf(2).signum() == 1,
BigDecimal.valueOf(3).signum() == 1,
BigDecimal.valueOf(4).signum() == 1,
BigDecimal.valueOf(5).signum() != 1,
BigDecimal.valueOf(6).signum() != 1,
BigDecimal.valueOf(7).signum() != 1,
BigDecimal.valueOf(8).signum() != 1);
BigDecimal.valueOf(1).signum() > 0,
BigDecimal.valueOf(2).signum() > 0,
BigDecimal.valueOf(3).signum() > 0,
BigDecimal.valueOf(4).signum() > 0,
BigDecimal.valueOf(5).signum() <= 0,
BigDecimal.valueOf(6).signum() <= 0,
BigDecimal.valueOf(7).signum() <= 0,
BigDecimal.valueOf(8).signum() <= 0);
}

ImmutableSet<Boolean> testBigDecimalSignumIsNegative() {
return ImmutableSet.of(
BigDecimal.valueOf(1).signum() == -1,
BigDecimal.valueOf(2).signum() == -1,
BigDecimal.valueOf(3).signum() == -1,
BigDecimal.valueOf(4).signum() == -1,
BigDecimal.valueOf(5).signum() != -1,
BigDecimal.valueOf(6).signum() != -1,
BigDecimal.valueOf(7).signum() != -1,
BigDecimal.valueOf(8).signum() != -1);
BigDecimal.valueOf(1).signum() < 0,
BigDecimal.valueOf(2).signum() < 0,
BigDecimal.valueOf(3).signum() < 0,
BigDecimal.valueOf(4).signum() < 0,
BigDecimal.valueOf(5).signum() >= 0,
BigDecimal.valueOf(6).signum() >= 0,
BigDecimal.valueOf(7).signum() >= 0,
BigDecimal.valueOf(8).signum() >= 0);
}
}