Conversation
|
The GUI images look great! This was a much more substantial PR than I was expecting, nice work! I'll run this with my V3 board and LED and review the functional algo soon |
| try: | ||
| try: | ||
| param = os.sched_param(os.sched_get_priority_max(os.SCHED_FIFO)) | ||
| os.sched_setscheduler(0, os.SCHED_FIFO, param) |
There was a problem hiding this comment.
This requires root privileges to set, is that already implemented?
There was a problem hiding this comment.
Ill have to verify the perms of the web-server. But im pretty sure its non-root. From what i read in the original that was a nice to have not a need to have. Is that the case?
If so this does handle it gracefully if it doesnt have root.
|
@connorgallopo should I rebase/merge this (locally) with feature/build-cleanup branch before testing? I'm planning on doing a completely fresh build to test the dependencies |
if you use the github cli you can just check out the PR - which in my opinion is the best/easiest way. You just will have to have a remote set for this upstream |
…I0 MOSI pin (GPIO 10)
…cs, manual DAC, etc)
92272ed to
c042fb0
Compare
Description
This PR take the foundations from #181 and updates them to be merge ready.
What does this PR do?
Refactors #181 to remove script anti-pattern, moving everything into the gui for an intuitive user experience.
Why is this change needed?
See #181. This change is required on top of 181 as we have removed manual scripts, so using them again is an anti-pattern and a step backwards.
Changes Made
Testing Performed
Test Environment
Macbook Dev Env
Hardware Compatibility
Documentation
AI (Vibe-Coded) Content Description
Checklist
Code Quality
Build & Test
./packaging/build.sh buildSubmission Requirements
git rebase -i HEAD~n)[PR TYPE] Brief descriptionAdditional Context
@peteattayek