Skip to content

Conversation

@Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Jun 5, 2019

Credit: https://github.com/Haoose/UPLAY_GAME_ID/blob/master/README.md

Blocked by: #978

Blocked by: #881 -> Can't test!

@Kreyren Kreyren changed the title Add AC_Odyssey Add Assassin's Creed: Odyssey Jun 5, 2019
@Kreyren Kreyren force-pushed the AC_Odyssey branch 2 times, most recently from a1cdba1 to ed6b07e Compare June 6, 2019 01:38
@qparis
Copy link
Member

qparis commented Jun 6, 2019

Does the game run?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 6, 2019

Does the game run?

Blocked by: #978

@plata
Copy link
Collaborator

plata commented Jun 6, 2019

Blocking pr has been merged. Is this working now?

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 6, 2019

Blocking pr has been merged. Is this working now?

Based on available info it should, but i didn't have the opportunity to test it on phoenicis yes so either push in testing or wait for me to test.

@plata
Copy link
Collaborator

plata commented Jun 6, 2019

In this case, please state this in the pull request description set the pull request to draft. Same for other pull requests like explained before.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 6, 2019

In this case, please state this in the pull request description set the pull request to draft. Same for other pull requests like explained before.

*push request, stop allowing github to confuse ppl :p

Insane, but okay

@plata
Copy link
Collaborator

plata commented Jun 7, 2019

Like explained before, we cannot accept untested pull requests. Therefore I will close this until it is tested.

@plata plata closed this Jun 7, 2019
@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 8, 2019

Why do we have testing flag then.. w/e i will adapt for testing then..

@plata
Copy link
Collaborator

plata commented Jun 8, 2019

To quote from the documentation:

testingOperatingSystems
Operating systems for which the script is in beta. Should be set if you are unsure that the script will run properly for everybody (like if it requires a huge amount of hack, or if it is not compatible with a any graphics cards, etc…).

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 8, 2019

@plata seems fitting for all my AC scripts

@plata
Copy link
Collaborator

plata commented Jun 9, 2019

No. You cannot even be sure that it works at all.

@Kreyren
Copy link
Contributor Author

Kreyren commented Jun 10, 2019

@plata because phoenicis is unable to install any steam game, adapt patches for games that depends on them like league of legends and your wine has different results compared to system wine.

if you provided system wine and resolved the quickscripts i can quarantee you that specified version of game will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants