Skip to content

Skills for vibe coding#2201

Open
TaranDahl wants to merge 8 commits into
Phobos-developers:developfrom
TaranDahl:AICommand
Open

Skills for vibe coding#2201
TaranDahl wants to merge 8 commits into
Phobos-developers:developfrom
TaranDahl:AICommand

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

Added the skills of Write Documentation and Generate INI tag

@TaranDahl TaranDahl added Tested ⚙️T1 T1 maintainer review is sufficient No Documentation Needed No documentation needed whatsoever labels May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot
Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/424/1

Copy link
Copy Markdown
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review, skills only

also we don't use RIP, EIP is the one we use

Comment thread .trae/skills/撰写文档-write-documentation/SKILL.md Outdated
Comment thread .trae/skills/撰写文档-write-documentation/SKILL.md Outdated

After user approval, write the approved text into the appropriate doc file. For sections in `docs/New-or-Enhanced-Logics.md` or similar, insert the new `### ` section in alphabetical order among existing sibling headings under the correct `## ` category. Look at existing sibling `### ` headings to determine the correct insertion point.

Continue with the INI code block following existing conventions:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the example from readme

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Comment thread .trae/skills/撰写文档-write-documentation/SKILL.md Outdated
Comment thread .trae/skills/检查钩子-check-hooks/SKILL.md Outdated

**Mode A — Specify a commit** (user provides a SHA or commit name):
```
python discover_hooks.py --commit <sha>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed? IMO it should be simpler, just use git instead

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to simplify?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the commit stuff from the script and just instruct the bot to checkout the commit hash

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe any problem that can be solved with a script should best be handled by a script rather than an LLM. LLMs are not entirely reliable; different models vary greatly in capability (not everyone can afford Opus, myself included 🤣), and their performance fluctuates over time and by probability. In contrast, a script always produces consistent results.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make a .bat to have git checkout and then python discover_hooks.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides, for LLM, what's the difference between

python discover_hooks.py --commit <sha>

and

git checkout <sha> && python discover_hooks

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make a .bat to have git checkout and then python discover_hooks.py

Checkout could be interrupted by things like stash conflict, which is hard to handle by LLM. Also, you must commit or stash everything before checkout, which is inconvenient.

Comment thread .trae/skills/检查钩子-check-hooks/SKILL.md
Comment thread .trae/skills/检查钩子-check-hooks/SKILL.md
Comment thread .trae/skills/检查钩子-check-hooks/SKILL.md Outdated
Comment thread .trae/skills/检查钩子-check-hooks/SKILL.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Documentation Needed No documentation needed whatsoever ⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants