Fix the storybook build #902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added `src/test/ng-mocks-matchers.ts` which apparently was being included by storybook in its build. This was causing some dependency issues. We don't need to include anything in the test directory in our storybook build, so the solution is to just ignore the whole thing. Issue #901 Fix Storybook build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 47.83% 47.76% -0.08%
==========================================
Files 351 351
Lines 11292 11292
Branches 1889 1889
==========================================
- Hits 5402 5394 -8
- Misses 5698 5705 +7
- Partials 192 193 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I ran dev build + deploy on this branch and it has fixed the storybook build / succeeded: https://github.com/PermanentOrg/web-app/actions/runs/21087412745/job/60653208915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where our test files were being included in the storybook build. This wasn't causing issues before, but some new tooling caused an issue that raised the need to ignore it.
Resolves #901