DRY our indexes #886
Closed
DRY our indexes #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now each our environments has a distinct index.html file which injects env-specific tokens. This also has a lot of embedded scripts in the file itself. The net result is a ton of redundant lines of code. This pattern is questionable overall, but a short term improvement is to at least put the common javascript into a single file and DRY out the repetition. Eventually we should probably have a single file which is decorated in various environments with relevant tokens as part of a build step. Issue #885 Reduce size of index.html
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
=======================================
Coverage 47.13% 47.14%
=======================================
Files 372 372
Lines 11495 11495
Branches 1913 1914 +1
=======================================
+ Hits 5418 5419 +1
- Misses 5889 5893 +4
+ Partials 188 183 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing this out in favor of #887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates a bunch of repeated scripts into a single file.
Ultimately I think we really want to change the way our index is built such that there is a single index, and anything environment specific is inserted as part of the build step.
Resolves #885