Add support for web archive rendering #861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up a special treatment for archive files (currently .wacz, .zip, and .7zip). This is very MVP and currently is trying to show the ReplayWeb example file for any archive uploaded to Permanent. This doesn't work because the "service worker" is not loading correctly.
In order to render the replay-web-page we need a web worker to run and we cannot use a remote one because of CORS, that is why we are adding the files locally.
Co-authored-by: Liam Lloyd-Tucker <liam@permanent.org>
We need to style the embed to actually fill the screen
We don't want to try to render zip files as web archives, so we're introducing a brand new type.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
=======================================
Coverage 47.16% 47.17%
=======================================
Files 372 372
Lines 11495 11497 +2
Branches 1912 1912
=======================================
+ Hits 5422 5424 +2
+ Misses 5891 5887 -4
- Partials 182 186 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Plan:
The goal is to not have this PR wait while we do infrastructure work to make playing JS as safe as possible. |
Contributor
Author
|
This issue is related: #863 |
Member
|
Can we actually hide this behind a feature flag? We had suggested that we would say "if WebArchive and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR captures the outcome of our 2025 hackathon! Go team!
It adds support for a new record type: Web Archive, including the ability to render that content via detail view.
Before this PR is merged we should do some additional testing related to javascript security.
We should also consider using an
npmpackage instead of loading the vendor script directly.