Include migrations in build output #230
Merged
+551
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo contains database migrations, and when it is deployed the first thing it does is attempt to run them. However, we recently changed the build script for this repo to use tsc instead of babel. Unlike babel, tsc ignores non-typescript files in its source folder and doesn't copy them to the output directory. This caused the migrations to not be present when we deployed this service, which caused it to fail to start. This commit add tscp to the build script to copy non-typescript files into the build output (we use the same tool in stela to handle SQL scripts).
liam-lloyd
force-pushed
the
fix_builds_to_include_migrations
branch
from
726466b to
6fc4619
Compare
cecilia-donnelly
approved these changes
Jan 9, 2026
Member
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
There was a problem hiding this comment.
LGTM. Thanks @liam-lloyd !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo contains database migrations, and when it is deployed the first thing it does is attempt to run them. However, we recently changed the build script for this repo to use tsc instead of babel. Unlike babel, tsc ignores non-typescript files in its source folder and doesn't copy them to the output directory. This caused the migrations to not be present when we deployed this service, which caused it to fail to start. This commit add tscp to the build script to copy non-typescript files into the build output (we use the same tool in stela to handle SQL scripts).