Replace File::Find with Path::Tiny #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"The journey of a thousand miles begins with a single step." We have discussed migrating to Path::Tiny (and started, see #1264 and #1544 for details), and this is the first concrete, discrete step in doing so. It takes a problem of small scope (app scaffolding and File::Find) to set the stage for the rest of the migration. There are a few TODO items here, and if there are better ways to handle them, I am all ears. If not, I will remove my comments when I merge. Feedback welcome/needed!
SysPete
requested changes
Mar 23, 2021
Member
SysPete
left a comment
SysPete
left a comment
There was a problem hiding this comment.
Great to see us start to use Path::Tiny, thanks @cromedome! Some ideas added.
SysPete
requested changes
Apr 12, 2021
Member
SysPete
left a comment
SysPete
left a comment
There was a problem hiding this comment.
Just one last comment, otherwise 👍
yanick
approved these changes
Apr 14, 2021
Contributor
yanick
left a comment
yanick
left a comment
There was a problem hiding this comment.
Looks cromulent. And yay to Path::Tiny!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"The journey of a thousand miles begins with a single step." We have discussed migrating to Path::Tiny (and started, see #1264 and #1544 for details), and this is the first concrete, discrete step in doing so. It takes a problem of small scope (app scaffolding and File::Find) to set the stage for the rest of the migration.
There are a few TODO items here, and if there are better ways to handle them, I am all ears. If not, I will remove my comments when I merge.
Feedback welcome/needed!