Skip to content

fix hardhat ignition deployment #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxnorm merged 3 commits into from
Apr 3, 2026
Merged

fix hardhat ignition deployment #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
106053d
fix hardhat ignition deployment
maxnorm Apr 3, 2026
3c9d8cc
update init text
maxnorm Apr 3, 2026
404aafc
add changeset
maxnorm Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rich-apples-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@perfect-abstractions/compose-cli": patch
---

fix deployment setup on hardhat
3 changes: 2 additions & 1 deletion cli/src/commands/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ async function runInitCommand(argv) {

logger.plain("");
logger.info("You're all set. We hope you'll Compose something great!\n");
logger.warn(`If this helped you, please give us a star on GitHub:\n${COMPOSE_REPO_URL}\n`);
logger.brightYellow(`If this helped you, please give us a star on GitHub:\n✨ ${COMPOSE_REPO_URL} ✨\n`);
logger.warn(`Please report any issues or feedback:\n${COMPOSE_REPO_URL}/issues\n`);
}

module.exports = {
Expand Down
4 changes: 4 additions & 0 deletions cli/src/templates/default/hardhat/ts/mocha-ethers/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import { configVariable, defineConfig } from "hardhat/config";
export default defineConfig({
plugins: [hardhatToolboxMochaEthersPlugin],
solidity: {
npmFilesToBuild: [
"@perfect-abstractions/compose/diamond/DiamondInspectFacet.sol",
"@perfect-abstractions/compose/diamond/DiamondUpgradeFacet.sol",
],
profiles: {
default: {
version: "0.8.30",
Expand Down
7 changes: 2 additions & 5 deletions cli/src/templates/default/hardhat/ts/mocha-ethers/ignition/modules/Counter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import { buildModule } from "@nomicfoundation/hardhat-ignition/modules";

import { DiamondInspectFacet } from "@perfect-abstractions/compose/diamond/DiamondInspectFacet.sol";
import { DiamondUpgradeFacet } from "@perfect-abstractions/compose/diamond/DiamondUpgradeFacet.sol";

export default buildModule("CounterDiamondModule", (m) => {
const counterFacet = m.contract("CounterFacet");
const inspectFacet = m.contract(DiamondInspectFacet);
const upgradeFacet = m.contract(DiamondUpgradeFacet);
const inspectFacet = m.contract("DiamondInspectFacet");
const upgradeFacet = m.contract("DiamondUpgradeFacet");

const owner = m.getAccount(0);
const diamond = m.contract("Diamond", [[counterFacet, inspectFacet, upgradeFacet], owner]);
Expand Down
4 changes: 4 additions & 0 deletions cli/src/templates/default/hardhat/ts/node-runner-viem/hardhat.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import { configVariable, defineConfig } from "hardhat/config";
export default defineConfig({
plugins: [hardhatToolboxViemPlugin],
solidity: {
npmFilesToBuild: [
"@perfect-abstractions/compose/diamond/DiamondInspectFacet.sol",
"@perfect-abstractions/compose/diamond/DiamondUpgradeFacet.sol",
],
profiles: {
default: {
version: "0.8.30",
Expand Down
7 changes: 2 additions & 5 deletions cli/src/templates/default/hardhat/ts/node-runner-viem/ignition/modules/Counter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import { buildModule } from "@nomicfoundation/hardhat-ignition/modules";

import { DiamondInspectFacet } from "@perfect-abstractions/compose/diamond/DiamondInspectFacet.sol";
import { DiamondUpgradeFacet } from "@perfect-abstractions/compose/diamond/DiamondUpgradeFacet.sol";

export default buildModule("CounterDiamondModule", (m) => {
const counterFacet = m.contract("CounterFacet");
const inspectFacet = m.contract(DiamondInspectFacet);
const upgradeFacet = m.contract(DiamondUpgradeFacet);
const inspectFacet = m.contract("DiamondInspectFacet");
const upgradeFacet = m.contract("DiamondUpgradeFacet");

const owner = m.getAccount(0);
const diamond = m.contract("Diamond", [[counterFacet, inspectFacet, upgradeFacet], owner]);
Expand Down
3 changes: 3 additions & 0 deletions cli/src/utils/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ const logger = {
warn(message) {
console.warn(pc.yellow(message));
},
brightYellow(message) {
console.warn(pc.bold(pc.yellowBright(message)));
},
error(message) {
console.error(pc.red(message));
},
Expand Down
Loading