Hotfix UDP Client vs Server#1411
Open
jonnyarndt wants to merge 4 commits intomainfrom
Open
Conversation
…t GenericUdpClient class
BREAKING CHANGE, existing `udp` control method is now `udpServer` and `udp` control method is now a udp client
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Essentials’ UDP control method semantics so udp is an outbound UDP client, while the previous listener/server behavior is preserved under a new udpServer control method (breaking config schema change).
Changes:
CommFactorynow instantiatesGenericUdpClientforUdpandGenericUdpServerforUdpServer.- Adds
UdpServertoeControlMethod. - Introduces
GenericUdpClientand updates GenericComm documentation to reflect the new contract.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.Core/Comm and IR/CommFactory.cs | Routes Udp to new outbound client; adds UdpServer case for listener behavior. |
| src/PepperDash.Core/Comm/eControlMethods.cs | Updates enum docs for Udp and adds UdpServer. |
| src/PepperDash.Core/Comm/GenericUdpClient.cs | New outbound UDP client implementation w/ receive loop + auto-reconnect support. |
| docs/docs/usage/GenericComm.md | Documents UdpServer, updates socket options list and clarifies address usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/PepperDash/Essentials/sessions/91306f72-52ee-4cef-97af-49599612d3ed Co-authored-by: jonnyarndt <21110580+jonnyarndt@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UDP control method contract in Essentials needed to change as
udpwas acting as a server not a client.udpcontrol method now represents outbound UDP client behavior.udpServernow represents local UDP listener/server existing behavior.PR introduces a BREAKING CHANGE or more specifically, a breaking configuration schema change.
Existing configurations with control method of
udpor listener-style UDP need to switch fromudptoudpServer.udpcontrol method now instantiates udp client.