-
Notifications
You must be signed in to change notification settings - Fork 61
fix: update deprecated QNode.transform_program code
#2385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QNode.transform_program codeQNode.transform_program code
kipawaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's also a reference to transform_program in jax_extras/tracing, transform_program = getattr(qnode, "transform_program", []). I think that's all though, looks good!
|
Hello. You may have forgotten to update the changelog!
|
Nice catch! |
Done: a46e508 |
kipawaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 💯
kipawaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…e` (#8906) Catalyst accesses the internal `QNode._transform_program` which makes this merge process a bit annoying. ⬇️ This private access results in failing documentation tests in this PR and will only be fixed once PennyLaneAI/catalyst#2385 goes in. After that goes in, we can merge #8945 which adds the deprecation warning and test coverage and unskips the documentation tests. This is done so I don't have to `xFAIL` a million things in the external-libraries-tests in this PR 😅. Therefore, the merge order will need to be, 1. #8906 (this PR) 2. PennyLaneAI/catalyst#2385 3. #8945 ------- **Eco-system** - Catalyst: PennyLaneAI/catalyst#2385 - Lightning: N/A **Demos** - QML: N/A **Plug-ins** - Qiskit: N/A - Ion-Q: N/A - Qulacs: N/A - AQT: N/A - Cirq: N/A [sc-105439]
…e` (#8906) Catalyst accesses the internal `QNode._transform_program` which makes this merge process a bit annoying. ⬇️ This private access results in failing documentation tests in this PR and will only be fixed once PennyLaneAI/catalyst#2385 goes in. After that goes in, we can merge #8945 which adds the deprecation warning and test coverage and unskips the documentation tests. This is done so I don't have to `xFAIL` a million things in the external-libraries-tests in this PR 😅. Therefore, the merge order will need to be, 1. #8906 (this PR) 2. PennyLaneAI/catalyst#2385 3. #8945 ------- **Eco-system** - Catalyst: PennyLaneAI/catalyst#2385 - Lightning: N/A **Demos** - QML: N/A **Plug-ins** - Qiskit: N/A - Ion-Q: N/A - Qulacs: N/A - AQT: N/A - Cirq: N/A [sc-105439]
|
@andrijapau looking into it! Reproduced locally but haven't solved it yet... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
==========================================
+ Coverage 97.17% 97.31% +0.13%
==========================================
Files 107 107
Lines 12951 12951
Branches 1075 1075
==========================================
+ Hits 12585 12603 +18
+ Misses 301 288 -13
+ Partials 65 60 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See associated deprecation PR in PennyLane: PennyLaneAI/pennylane#8906
[sc-105439]