Skip to content

Conversation

@Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Jan 26, 2026

Motivation

  • Prevent CORS failures by preloading the Rubrik font from the bundled static asset instead of an external URL.

Description

  • Replace the external Rubrik preload link with a local reference using {{ url_for('static', filename='fonts/rubrik/TPRubrik-Regular.woff2') }} and remove the crossorigin attribute in app/templates/base.html.
  • Run black . to reformat code, which modified app/nl_query.py (no functional changes).

Testing

  • Ran pytest tests/, which completed successfully with 9 passed.

Codex Task

Copilot AI review requested due to automatic review settings January 26, 2026 00:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Rubrik font preload to use a bundled static asset (avoiding external preload/CORS issues) and applies Black formatting to app/nl_query.py.

Changes:

  • Replaced external Rubrik font preload URL with a local url_for('static', ...) reference in the base template.
  • Removed the crossorigin attribute from the font preload link.
  • Reformatted app/nl_query.py with Black (no intended functional changes).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
app/templates/base.html Points Rubrik font preload at a local static .woff2 asset instead of an external URL.
app/nl_query.py Black formatting change around GENERATE_QUERY_PROMPT declaration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Ulthran and others added 3 commits January 26, 2026 11:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Ulthran Ulthran merged commit a86b8e3 into main Jan 26, 2026
5 checks passed
@Ulthran Ulthran deleted the codex/remove-external-font-url-usage branch January 26, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants