Added Both Revoke and Read function to the Blob Extension #439

faunks · 2025-11-27T17:47:52Z

TheShovel, what's up pookie ;P

vercel · 2025-11-27T17:47:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
penguinmod-extensions-gallery	Ready	Preview	Dec 24, 2025 1:34pm

TheShovel · 2025-11-28T13:04:25Z

reading an empty blob returns the penguinmod home page. It shouldnt do that. Make it return nothing.

reading anything as an image returns a object that cant be used because of scratch parsing.

fix these

Steve0Greatness · 2025-11-29T08:44:47Z

static/extensions/Faunks/Blobs.js

+
+        if (mime.startsWith("text/") || mime === "application/json") {
+            const text = await blob.text();
+            return mime === "application/json" ? text : text;


~~Just return text, here.~~ On second thought, condense this into return await blob.text();.

Steve0Greatness · 2025-11-29T09:07:53Z

static/extensions/Faunks/Blobs.js

+        const response = await fetch(url);
+        const blob = await response.blob();
+
+        if (!url.startsWith("blob:")) return "";


Why are you only just now checking if the url is actually a blob? Check before you fetch.

Steve0Greatness · 2025-11-29T09:32:26Z

static/extensions/Faunks/Blobs.js

+          {
+              opcode: "readBlob",
+              blockType: Scratch.BlockType.REPORTER,
+              text: "read blob [URL] as a [TYPE]",


This casing on the reporter here is inconsistent with the other blocks.

Steve0Greatness · 2025-11-29T09:39:30Z

static/extensions/Faunks/Blobs.js

+        return btoa(binary);
+    }
+
+    return readBlobContent(args.URL, args.TYPE);


I'm pretty sure if this is all you're doing, you don't even need to have another function inside here, just make the function root async; in any case, this will be returning a promise, so it really doesn't matter that you did it this way.

Another note about this because I feel like this is important, I'm asking for the method to be made async and for it to directly return rather than routing it through another function. This is all around more readable, at least in my opinion.

async readBlob(args, util) { ... return btoa(binary); }

feel free to disagree, here, though.

Steve0Greatness · 2025-11-29T09:46:20Z

static/extensions/Faunks/Blobs.js

+        const buffer = await blob.arrayBuffer();
+        const bytes = new Uint8Array(buffer);
+
+        let binary = "";
+        for (let i = 0; i < bytes.length; i++) {
+            binary += String.fromCharCode(bytes[i]);
+        }


Could just be me, but I think there might be more efficient ways of converting an array buffer into a string. Maybe TextDecoder, or utilizing a DataView instead of Uint8Array. One thing that I know for a fact is that V8 (Chrome) handles DataView more efficiently than Uint8Array: https://v8.dev/blog/dataview. Not sure on the state of Firefox, here, though.

Everything is done! thanks for the feedback btw, I was kind of rushing adding some of the stuff (to which I apologize), from now on I will try to do stuff and put more work into it(which may slow things down because the main reason of which made me rush things up is a really tight time schedule). If you have any other stuff you want me to add I would be more than happy to do so.

Could just be me, but I think there might be more efficient ways of converting an array buffer into a string. Maybe TextDecoder, or utilizing a DataView instead of Uint8Array. One thing that I know for a fact is that V8 (Chrome) handles DataView more efficiently than Uint8Array: https://v8.dev/blog/dataview. Not sure on the state of Firefox, here, though.

That blog article says otherwise? "We found that our new DataView implementation provides almost the same performance as TypedArrays when accessing data aligned in the native endianness (little-endian on Intel processors)"

I couldn't remove that one loop and I spent a long time trying to do so, if you have any more stuff you would like me to change I would be more than happy to do so

Steve0Greatness · 2025-12-02T04:26:27Z

static/extensions/Faunks/Blobs.js

+    readBlob(args, util) {
+    async function readBlobContent(url, mime) {
+
+        if (!url.startsWith("blob:")) return ""; // I WOULD return "Url Error", but it would make it a bit harder to track if an output has been returned or not


You could throw an error. So throw new URIError("must be a blob url"); or something similar.

thanks. I've just added it so it would do that (I hope it also acts as a return method)

Steve0Greatness · 2025-12-02T04:30:37Z

static/extensions/Faunks/Blobs.js

+            return await blob.text();
+        }
+
+        const buffer = await blob.arrayBuffer();


After doing a bit of looking at the MDN documentation for Blob, there may be a way of doing this with a readable stream, although I'd need to check how efficient that is. Also quick note that the text method doesn't seem to require text to actually be text, so it can pretty much be anything and still be interpreted as text.

I could also be wrong about this.

I don't think it's worth spending time on concidering the extension already runs really fast and uploading bigger files would be an issue by it's one to be honest, I think it would be better for this chunk of the code to be as is instead of spending time on how we could improve it right now, a think that we can and probably may happen at some point.

Steve0Greatness · 2025-12-02T04:33:45Z

static/extensions/Faunks/Blobs.js

+        for (let i = 0; i < view.byteLength; i++) {
+          binary += String.fromCharCode(view.getUint8(i));
+        }
+        return btoa(binary);


What's the purpose of reading the text as Base64? PenguinMod will be able to handle direct binary-encoded data, pretty sure.

Also, I think that outputting it as b64 could be considered unexpected behavior, mostly because input isn't given in base 64.

so what do you recommend the output being?, if you're just saying to output the raw data then sure I would just return it if you like.

Yeah, I think outputting the raw information is the best option.

I just spent like 2 hours, scratch cannot handle raw bytes,

this just destroyes the image.

thats not a scratch thing though, thats the javascript

The block explicitly casts any input to a string before saving it to an object URL. Whether this is Scratch's or JavaScript's fault is, for all purposes, entirely irrelevant. Non-JS string safe characters cannot be added to an object URL due to the limitations of this extension, and so no non-JS string safe characters couldn't possibly be read from an object URL, unless someone is utilizing another extension that allows for that, or are directly encoding things to an object URL through a JavaScript eval extension. That was my point in the first place.

it was the point of my reply, and what you said there doesnt match what you say now in how you lay it out

read should not be using string btoa, js strings will naturally corrupt binary data due to how they work
if its intention is just to return some handle for the data that can be referenced later, this will need a custom base64 encoder
however if its intention is instead to provide data in a way the project can read all on its own, it must be in a raw byte format, such as 0,255,127,63,31,15,7,3,1
i am fairly certain that the later is the intention, not the former, since the block provides types for things like gltf and obj, where the intent of loading such a file is likely specifically to get something that the project intends to manually render, and also provides formats like json and text as the actual data rather then as a base64 string

it was the point of my reply, and what you said there doesnt match what you say now in how you lay it out

That's what the intended meaning of my point was, if that doesn't come across at all then that's my bad.

Here's some bullet points on what this does: * Allow extension users to choose what they want to be outputted, rather than deciding automatically based on the MIME. * Correct base64 encoding: encoding through first writing it to a string is not only a relatively slow way of doing such, but is also not safe, due to the potential for data loss. * Added 4 encoding types, available in both the read and write blocks for blob URLs: base 64, data URL, plain text, byte array. * Base 64 reads it as base 64; note: not a string encoded to base 64, but as binary data that was base 64 encoded. * Data URL resolves the data URL and uses its content to write to the object URL. * Plaintext just takes in the input as plaintext, just as it was done before. * Byte array takes in an array of numbers that are between 0 and 255 and reads it as a string of bytes. Outputted as a JSON string so as to be compatible with other extensions such as Arrays.

Steve0Greatness · 2025-12-20T04:58:20Z

Feel like I should properly mention that I made a PR on your fork that fixes the most major issues I have with this PR: faunks#1. More details are available on that page.

Use encoding types instead of just using plaintext.

Added Both Revoke and Read function

1b09c84

TheShovel, what's up pookie ;P

vercel bot deployed to Preview November 27, 2025 17:48 View deployment

JeremyGamer13 added the extension update This updates an already existing extension label Nov 27, 2025

Fixed Unsafe stuff

b98564f

vercel bot deployed to Preview November 28, 2025 13:37 View deployment

Steve0Greatness suggested changes Nov 29, 2025

View reviewed changes

Switched to DataView [and more small fixes]

2483fe3

I couldn't remove that one loop and I spent a long time trying to do so, if you have any more stuff you would like me to change I would be more than happy to do so

vercel bot deployed to Preview December 1, 2025 13:21 View deployment

Steve0Greatness reviewed Dec 2, 2025

View reviewed changes

Update Blobs.js

fbe1f14

vercel bot deployed to Preview December 2, 2025 14:28 View deployment

PenguinMod deleted a comment from Coolestcoderexist Dec 11, 2025

Steve0Greatness mentioned this pull request Dec 20, 2025

Use encoding types instead of just using plaintext. faunks/PenguinMod-ExtensionsGallery#1

Merged

Merge pull request #1 from Steve0Greatness/blobs-patch

e178b85

Use encoding types instead of just using plaintext.

vercel bot deployed to Preview December 24, 2025 13:34 View deployment

Added Both Revoke and Read function to the Blob Extension #439

Are you sure you want to change the base?

Added Both Revoke and Read function to the Blob Extension #439

Uh oh!

Conversation

faunks commented Nov 27, 2025

Uh oh!

vercel bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheShovel commented Nov 28, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Steve0Greatness commented Dec 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vercel bot commented Nov 27, 2025 •

edited

Loading