TheShovel/extexp.js: QOL changes #423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyGamer13
added
the
extension update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close this pull request under past pretense that the code is the same, whatever gripes JWK had with this have been completely changed to match a less strict and more user friendly alternative suggested by jeremy. and for jodie, if you read the code and the previous pull request comments this does not break functionality.
This pull request:
If I missed something then just comment it and I will add it.
This improves the speed of the run function based on benchmarks I did (GSA's used my outdated code he said): #417 (comment)
supersceeds the illy closed #417 after a big review by GSA