-
Notifications
You must be signed in to change notification settings - Fork 17
Improved trajectory_projector calculations through vectorization #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
awestphal1
wants to merge
44
commits into
PedestrianDynamics:main
Choose a base branch
from
awestphal1:use_numpy_functions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
785c7ec
added preprocessing and trajectory_projector
awestphal1 61be7f9
started editing user guide, added test file
awestphal1 12111b4
Fixed Float_Precision Problem and added tests
awestphal1 c5d0f8c
Current update
awestphal1 9ac8ec5
new distance function
awestphal1 1d47c0b
errors for false parameters, better structure, method for catching in…
15d9c87
Added Errors for Exceptions
62caaa6
Finish documentation
16c537b
Merge branch 'preproccesing' into main
a3d82d6
changed list structure for geo_data into dataframes
awestphal1 9414d93
Fixed Docstring Notation
awestphal1 8030b73
Updated min_ - / max_distance to user_guide
awestphal1 2e33e50
restored docs/source/ notebooks from main
awestphal1 bde30d7
Merge branch 'preproccesing'
awestphal1 46ac491
Merge branch 'PedestrianDynamics:main' into main
awestphal1 219a5d3
Fixed destroyed symlinks
awestphal1 3bd2c3b
Symlinks describtion for Windows User in developeterguide
awestphal1 f19b5be
Fixed import statements
awestphal1 2ac34d1
added a visualization for the min-/max-distance parameters
awestphal1 9aabe50
added a visualization for the min-/max-distance parameters
awestphal1 afa0168
Merge branch 'PedestrianDynamics:main' into main
awestphal1 07a1534
deleted worse .svg image
awestphal1 cb39276
Merge branch 'documentation_preprocessing'
awestphal1 78a8adf
Merge branch 'main' into main
awestphal1 4d9ef1d
Improved the plot for showing preprocessing parameters and corrected …
awestphal1 29ca64a
Merge branch 'main' of https://github.com/awestphal1/PedPy
awestphal1 d26ce82
adapted init so tests hopefully run through
awestphal1 b38b4d9
Merge branch 'PedestrianDynamics:main' into main
awestphal1 4e94f79
added file trajectory_oulier_detetction + code
awestphal1 e2222b2
implemented tests for outlier detection
awestphal1 9b5eb0c
fixed personID counter for drops_only
awestphal1 e507e2f
added outlier_detection documenatation to preprocessing notebook
awestphal1 abf8462
finished outlier_detection and correcting_invalid_traj in preprocessi…
awestphal1 7ed1a73
Merge branch 'PedestrianDynamics:main' into main
awestphal1 805cda4
finished documentation
awestphal1 5f9f0f3
Merge branch 'detect_outliers'
awestphal1 90297cc
pre-commit issue solved
awestphal1 90a465d
improved documentation
awestphal1 f64e8f2
Edited the preprocessing notebook
awestphal1 422ef32
Merge branch 'PedestrianDynamics:main' into main
awestphal1 42e251f
vectorized calculations trajectrory_projector
awestphal1 3b83d12
improved documentation
awestphal1 eea00a6
Merge branch 'main' into use_numpy_functions
awestphal1 b8375b1
more test cases + added normalization to WalkableArea
awestphal1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2,121 changes: 2,121 additions & 0 deletions
2,121
docs/source/images/invalid_trajectory_person_7_corrected.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1,163 changes: 1,163 additions & 0 deletions
1,163
docs/source/images/invalid_trajectory_person_7_original.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3,524 changes: 1,762 additions & 1,762 deletions
3,524
docs/source/images/voronoi_cutoff_differences.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| C:/Users/alexa/PycharmProjects/PedPy_/notebooks/preprocessing.ipynb |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| =========== | ||
| User Guide | ||
| =========== | ||
|
|
||
| .. list-table:: | ||
| :widths: 20 80 | ||
|
|
||
| * - :doc:`user_guide.ipynb` | ||
| - Notebook providing an overview of the functions offered by PedPy | ||
| * - :doc:`getting_started.ipynb` | ||
| - The notebooks guides through the first steps to set up an analysis of a pedestrian experiment | ||
| * - :doc:`preprocessing.ipynb` | ||
| - Notebook covers validation, cleaning, and filtering of the data. | ||
| * - :doc:`fundamental_diagram.ipynb` | ||
| - For result-focused workflows, this notebook explains area-based fundamental diagrams | ||
| * - :doc:`fundamental_diagram_at_measurement_line.ipynb` | ||
| - This notebook also explains fundamental diagrams , but also focuses on line-based evaluations |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general hint:
I assume that the plots are created using matplotlib and some of the provided demo-data. In that case it would be great if you could add the creating of the plots to the readthedocs notebook. Then we could re-create the images easily when some behavior changes. If it is now too much work, that can be later also.
Note: the axis are not scaled equally, hence the geometry is distorted