some improvements #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (had some trouble cause i didnt do it after setting period, so i thought it would be nice to have it in this method)
|
The trick does not work on 32u4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a proposed fix for the unwanted interrupt when calling start. i had no chance to test it as i didnt have this problem, but i think turning off the interrupt should work
i also added an optional argument to the setperiod function. when setting the period you usually also want to reset the timer, but when i did this i never really thought about it, so i put this argument in the function so when looking at the functions code people can see that they mightve forgotten to reset the counter.
also i think the examples dont work, as the timer isnt started, but i didnt change that.