Open
Conversation
|
@pnadolny13 @kyuhanpathlight @vivqu {
"type": "object",
"properties": {
"email": {
"type": "string"
},
"id": {
"type": "string"
},
"name": {
"type": "string"
},
"username": {
"type": "string"
}
}
}But the csv loader fails with ValueError: dict contains fields not in fieldnames: 'selfUri', 'division__id', 'division__selfUri', 'businessUnit__id', 'businessUnit__selfUri' Ideally the schema would match the output and selecting specific streams would work, but just respecting catalog selections would likely solve the immediate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone in the Meltano community posted in slack about how this tap didnt respect their catalog selection criteria, this PR should add support for enabling/disabling streams and properties using meltano.
I dont have access to an account to test but I did validate that deselecting all streams passed with logs saying that they were skipped, then enabling one stream caused it to raise a 401 error due to invalid credentials.
@vorpal56 @kyuhanpathlight I know this is a fork of the original tap but it looks like this repo has been the most active and has seen the most recent commits so thought it was appropriate to create the PR here 😄 , let me know what you think!