dev(8948): Added functionality for multiple notes. #9456
+213
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8948 .
Description of the problem being solved:
The original ticket was requesting the ability to have multiple notes both for POE 1 and 2. I have had a look at the codebase and had a stab at implementing this feature request.
Instead of 1 global notes section, this PR introduces the ability to have multiple notes for a build and allows you to create, delete, reorder and set which note is active for the build, keeping the formatting of the editor.
Steps taken to verify a working solution:
Defaultnote, saved, exited and reopened the build to verify that the changes were savedLink to a build that showcases this PR:
https://maxroll.gg/poe/pob/a13ev0o0
Before screenshot:
After screenshot:
This is the new XML structure when the build is saved: