Skip to content

Add support for Impale#1820

Open
Peechey wants to merge 6 commits intoPathOfBuildingCommunity:devfrom
Peechey:feature/impale
Open

Add support for Impale#1820
Peechey wants to merge 6 commits intoPathOfBuildingCommunity:devfrom
Peechey:feature/impale

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 9, 2026

Description of the problem being solved:

Adding a statMap for Bonestorm's and His Vile Intrusion's more impale magnitude, but more importantly, re-enabling Impale as a whole. We've had Impale Chance zeroed out for a while and didn't look at any %chance mods. This PR enables impale dps with Bonestorm, His Vile Intrusion, Impale Support, Impale nodes, and Dreadfist Unique gloves.

The changes in CalcOffence is reverting back to what we had before.

This PR does NOT enable Crystalline Shards
Also does not support "Cannot Extract" which I think would mean we need to be able to disable impale damage for skills that have impale chance

Update: I fixed the base stored damage from 10% to 30% but I have not updated the images yet

Steps taken to verify a working solution:

  • Validate Impale DPS for affected skills
  • Validate Stored Damage is scaled correctly by More Magnitudes
  • Validate impale chance with crits with Dreadfist
  • Validate impale chance from Tree

Link to a build that showcases this PR:

eNrlXG1v4zYS_rz-FYKBAl0sYkuyHSdBtoXjOJsAyca1k-3dpwUj0bYutOSKVBK36H-_GZJ6sRM5ZFLgrncFmkrUPDPkcGY4HNI9_vlpyZwHmvIoiT83vZbbdGgcJGEUzz83b2_O9g6aP__UOB4TsbienWQRwy_-T40Px_LFCRYkJYGg6SV9oGyQieQqCennpkgz2nSWJIqnSXBPxZc0yVafm37TeYjoo6K5uBpfT26ajiDpnIpveSfc717TYcgOOtR0AkY4_0qWAJiQeE7TpkN4QONwWH74msS0CZ36cDxmZE3TqSDC4fDnc3MAgyNzekqW8BekE5YBoNM_9Fsdr9Pvdw96_V6zvRN8kqVcvI3DdEVpWIDc1v5-v3940PMBc9jz6lDjlI5mMxqI6IEO00gMFyQOStn9VrcOaU99lTERrViEitUIv-XXDuj8GX_PdeuIbxJB2Ol4WnLudfxWz_V6vYP-vre_G5eIUnGvUVaF1BJfLFeE0SrpQbfl9TsHHc9zvcNaNf0aicVzbAeG0OrCH7d32KsHDzPGwGeMOjihnKYPRIAfGNEPk-VdFNNw8DC37dYgpeR6pqxsQsIo41dUpJRXjKDWBq5ITIYJL6fHqzdlpB3TFBxWbEDcVwBTGiTg4xtSXLd10On3-v0DMCATiS_zqRV9Gc2oOaXVqDTAtjdvG8doakpnzfhtHZpA5DSjnCYZM6QUZcDq1zvUb1U6b79TR3lKnyrmXBtBYmEktErn9fr1Qh8SdHaDOJdGd5mghgFxdD4uKHu9luv29rsdf7-_363tynix5lFA2BV5ipbZEsL8DbmnZc_ql7jLaL4QMYS4Omi3VulnUUrtUcOEhW9ALUjC62D7O2JdFJ-TOBwEQQaZzrqMj25tBDol6X1MOTcN-DQ0R2BUMOg25B3BEdJexEFpCruY3sap7owBewRMIABgfnTHqCGiFKHDiEkOoUTNaazlrc10dElpsPgCkweiYLrN1p1SU-5OxSJtVbE7mb6g2J4hwEJNCHxZTf4uiLWapqsojYx6pChfGL0FxkIBo5im8_V0EVEWGqxkFepcY0OyMhk_zH8VbWQHm-KsjLkKtZ4tXHht5T0QXl2S-rs1oajNlPBAQrq1eaiPu5RRaoUYp8m_cMvE7GAwDMbsEW-UdkpnDGFJPIE0P56_rjWN2BLg1uf1yySrZDy-v3P-FLnR9OUZgtoIT2iYBRu5S31QK_ayJywJ7k1HUqCkvq2gAyFIcH-ahHNqCpFCrBCb_ZtmqxVELXQGUwaY_UACEFWy3b2eAfU1OLJRrMJEyVxASW0soEj9zKVsQczHgunblhgTYmMBxXReQaBcwqIjSzdXSWXd2lGu4RSm_MV9dO0O_CxjzGiXLwkNSxzj5BHGu8CKGrejhtS4rCHUdiWl8e9rY_4b5EYCRnEIaTbo0ljGNuIlMSfZbMadIFneEXEJRvG52XTuoC1_htSeU_2iEDfREhYgzk-JIA6XJcyziAmangIVSsMeOaHev30jaURi4cmC5VajLxs5JWmwQBFnhLE7iE4ot2zVgo_bsqyKT8MknkVzh6gioHyZUoHMZAeLFkdEglG5TpCMgXNEYU704fgiXmXCiWWRlMZ0ub7gJwluM7hIZYlXvrUVMag2oAuIAjStQnQJM86WdzSFfCBPwV4CLItiItbMaErDKUbiYZKBP1E2K9nke-xasRiO8pprAfJNRKtSHb-OR8ingn5F4rNolgM77itIjM02fVUDrEa0HOWagLZF7VDlcBHB2oRzwM0VUS0iG8iQmDzvKHRmoDJrPctDBvNx6EwlYUyeHFRt2MSOpiKLY4rbA1gNmIUhFSl0DvC7BhrH3OpXSmQdYHvGfKMOn0awhkHIFYPlMkEFhxZzXskVzOcj9xhr48_DqNkQCx1ty-mYxSKIsun6llvO5QuK_QJ_INs31y2P5hG7nsmFFiZVrmgGsJAuk_gsSZfPXHfHgKdBAquJhbNPF7Cw2QaHzW3A8yk_bhdLk1zQ1Bs-3qSUfovoo_N7kiz_CYiD_cOWt-_3Pfew5x7ky-FUpLg2ItGlPgX01Os_cPyHfqvf9134t3OImEXyiNlAPkUB5fr0Ua6nsBYkqXDoE_5nTFKx_tycEcb1Z-ySXmJxO1SsrvgC3cEKN0nXg_K88QIW1zhi-RkkmPD6Ioa0ICYMP-njSnx0N84pdUuchNi_ntvtHTYdgQopjz27ObrC0MdDVA7va5WfAlgv7beTS_nwYSHEih-124-Pj60VEYtkRp9gW9qCdKe9AnYwtj1-D8vAHsprD-Cfk_lA_iMZtXNOx-qoluv5x8w5jaC_SswxbKpUETr_gEnEVzUgzHqeiucoFvmz5tXeYHbcRv1K68AJwIcpdpADF5nEfKHLXzLCIpwt0BqHuYMmfrKGHPgMCyHl0ZfMivUMIg-dI21i8vPokr22rBhcrKh5a2OCjZzC3qxXOIbB5aU2Cs1_I8OSjQ5EhTtGw-q596Ds05CwgMtebX2QbVEcsCykF7HeEOQG6jByh31sav1Dj7blYAYMHbqIQfvaLud0iXYDmxASQu7avhCghDZg21IiPJwksMIIGDimyTJFRUClVRrLRptKuotTeQjVzm-V-QkwvZNjwTihHKnKr9JLrQrZVTWYLyy5I8zPh1Rt9CqeLK0GO_Y3Uzsv9H5JyWrKyKbay8ZC63nTG5SOUEez-2uUvjV-raIdRlZ4j8rCNwarmjRJZcS6RX3eGrb3-qhzSf9n9vQNgjykUWm2ystwhaK3PxWa3vzwBgs7j7iDTBxYpNJMZbl_vX_rxzyFUIuDXM5RDTrc43Me7TNO1Xk0JNCrJJbNWv31CYKUhFyqAX0CWhTrI2cymIwaIyYrQYQ5wGE2awzoHMYPS1MKKzKXTcOUzAQNjxxk2RindBY9HTl_pLjhOHJbvT8vE0iWBmFIw3KXePOY4JniwffdgHILnAN202-l4wVoms1eBF3EQUoJpMWqXio3-p1a6nyPAvlZdK-rpC9Sq8mVBfwy9oGF6f6oKeo29Ap_5PhuQ36f0N-OnP5hA_yZRUEk-JHjNf6ApJkf3WH198-KjE8_ev6ed_DxB0ckjqwN41U06FEDNMGdgx62ex3PQaU7Sh_qU9-Vn9y-g-rd_IRffNd1CkXmnz_5ra4UlSvBOY-Eo3TQ8Pwf0PuVKh2lS0cqs_FpH0FydE4ycwjEGKkXR5m0NPurJJTbU0eODi-J9fIijnaMWgr_VYrOqxTdVyl6r1Lsv0qRnyLJQLbpeP4LjpdvMhz_3LmCbUjjjMQEFO_ABgxSXLJc0tTQ9Qoj39y46JPF3htxg_JGgDrI6e12zU0m2hP2_16eefCSZxLZwT-VaEzgMViuYBuzyH3H62_4RzG1Vc_zu-gnXe_Z10-e5-GnXNmO0vZ_xiH_J9yts-lut18vfrkdNU5BWeEs4qJxkjDcb4LiriIheEMV9mDCfR-MgcwzegST8xij-sSCOueQJNRYjN-vWozbqFjijz13z3PdjxsTJSVtUPnuXmeTqJhvZSAO7DMy3qhaAQfqGQgVjkoMtz4GJI4T4YyeBF5czmm2hXof0U5-7Hh73cOPpVXeLJI0BitXxvlfEL17L050uUndkRnpxJeBMiKh0k2_qSs9itjBtBY-je9uJ5flZn4D4uaQwTJjVFgAzilbWgF0p3wLyEkSrp28NG0tyJk-4smhhbREcAv6CWYYni3AtwV0LAB4iLa0EnFJ7bqUm5atcgeW_VIjsdHuGaxa9yaITo6A9fSBcutO2UzICWXCcjY8S63a6-ileVAhSG3ZsLBKQgg8WM_9lWI2zdXxptzAyeNN3CiqgFU5o5Qb1e-qpFw5GtASqpTLiAff8QwXf0tSnmeOzs5Gw5uLbyMNmarLNg7P7rh6xE0wfZTL_SnsriPGVSTVO068a4NbX8bIipclj3puEndeHk0gr8qrBafRE00xuZHHFRHV_SrfbDuluoDXvvA0W3GTP6qwYKSSpyHhAhIvzUMfCFtwwRVYD2cobw9aYPPqThSWz7aaEFjJXdEgmkUB1gKqU45VXt1mo5fiOrCe7_y81ILHCZN6RAb60QI8TiKOxRdE5882Wp3HUT6f-bMF_JQGRI9dP1qAi1uMSSwvMUZhpc2K09cklkYOTjOIGJZq9MyOGC0bLBhe46UFfdKiOF1BnCka7BxHnZZoPtV3G13J695SQ_LJAqouNMsxyCcbp9GXfJW3R7Yuu3kVV87HRosFK3UkrXWYn0_bTEOe-4Xls81I8pN8OYj8xcZRZAwePCRRqOKDdJntRqugkQT372cjbzr-BWyK66zv5yVTCz3T-bMF_FZEuAV9hUtZb651t_dxQF97HweZI74ZPSmSkMl2_mEgd56Hq-LFHF9cxHszB3Vd8M1wecnizWgZ-sGe5QlBGfvLFpv4KbL4FJRROsabWclubcWPWmYmQ9TrouFIX-Goy5nqt1RlANANtnESlvHzIlF8K6fiHu85JUwsxknC3sfw2W_G3sMMf4eRrUgc5uyuN9PzGravTUMiOPCUd0dP8ece79WhvKJlwKi8aNPON3THXxOhrnlga_5yLO_eOCHlsMMhem1meI9mtaJxebI8XSSPg_ABbf0GZo5X-nrcfvZ_Ifg3Pn308w==

Before screenshot:

image

After screenshot:

image image

Dreadfirst critical hits impale on Leap Slam
image


new configOption
image

@Peechey Peechey added the enhancement New feature, calculation, or mod label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant