Add support for Impale#1820
Open
Peechey wants to merge 6 commits intoPathOfBuildingCommunity:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding a statMap for Bonestorm's and His Vile Intrusion's more impale magnitude, but more importantly, re-enabling Impale as a whole. We've had Impale Chance zeroed out for a while and didn't look at any %chance mods. This PR enables impale dps with Bonestorm, His Vile Intrusion, Impale Support, Impale nodes, and Dreadfist Unique gloves.
The changes in CalcOffence is reverting back to what we had before.
This PR does NOT enable Crystalline Shards
Also does not support "Cannot Extract" which I think would mean we need to be able to disable impale damage for skills that have impale chance
Update: I fixed the base stored damage from 10% to 30% but I have not updated the images yetSteps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Dreadfirst critical hits impale on Leap Slam

new configOption
