Add support for changed Smith of Kitava nodes #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for: +200 to Armour for each Connected Notable Passive Skill Allocated Body Armour grants +100% of Armour also applies to Chaos Damage Body Armour grants Unaffected by Damaging Ailments Implemented the connected nodes one to be specific to Smith of Kitava where it is actually checking for the number of nodes that have the `applyToArmour` flag on them. Implementing proper logic for number of connected notables would be a lot more difficult and less performant so we will cross that bridge if GGG ever decides to use the mod elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for:
+200 to Armour for each Connected Notable Passive Skill Allocated
Body Armour grants +100% of Armour also applies to Chaos Damage
Body Armour grants Unaffected by Damaging Ailments
Implemented the connected nodes one to be specific to Smith of Kitava where it is actually checking for the number of nodes that have the
applyToArmourflag on them. Implementing proper logic for number of connected notables would be a lot more difficult and less performant so we will cross that bridge if GGG ever decides to use the mod elsewhereLink to a build that showcases this PR:
https://maxroll.gg/poe2/pob/mmbzh0uy
Before screenshot:
After screenshot: