Skip to content

Fix Pathfinder's alternate start nodes not connecting #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Dec 16, 2025
Merged

Fix Pathfinder's alternate start nodes not connecting #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790eb00
Fix Pathfinder's alternate start nodes not connecting
Wires77 Dec 16, 2025
3755a2d
Add logic for unprecedented multiple choice node with multiple connec…
Wires77 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Classes/PassiveSpec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,14 @@ function PassiveSpecClass:AllocNode(node, altPath)

if node.isMultipleChoiceOption then
-- For multiple choice passives, make sure no other choices are allocated
local parent = node.linked[1]
local parent = nil
for _, possibleParent in ipairs(node.linked) do
if possibleParent.isMultipleChoice and possibleParent.alloc and possibleParent ~= node then
parent = possibleParent
break
end
end
assert(parent) -- If we're allocating a multiple choice option without an allocated parent, something has gone wrong
for _, optNode in ipairs(parent.linked) do
if optNode.isMultipleChoiceOption and optNode.alloc and optNode ~= node then
self:DeallocSingleNode(optNode)
Expand Down
8 changes: 4 additions & 4 deletions src/Classes/PassiveTree.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,16 @@ local PassiveTreeClass = newClass("PassiveTree", function(self, treeVersion)
goto endConnection
end

if node.ascendancyName ~= other.ascendancyName then
goto endConnection
end

if node.id == otherId then
goto endConnection
end

t_insert(other.linkedId, node.id)
t_insert(node.linkedId, otherId)

if node.ascendancyName ~= other.ascendancyName then
goto endConnection
end

if node.classesStart ~= nil or other.classesStart ~= nil then
goto endConnection
Expand Down
Loading