Skip to content

Update aspire hosting samples#8265

Draft
rbev wants to merge 36 commits into
masterfrom
aspire-hosting-samples
Draft

Update aspire hosting samples#8265
rbev wants to merge 36 commits into
masterfrom
aspire-hosting-samples

Conversation

@rbev
Copy link
Copy Markdown
Contributor

@rbev rbev commented May 20, 2026

  • add new nuget to packages list
  • simplify samples/hosting/aspire using Aspire hosting package
  • new samples
    • samples/aspire/platform
    • samples/aspire/platform-asb
  • new section under platform platform/aspire

Comment thread components/nugetAlias.txt
ASQN: NServiceBus.Transport.AzureStorageQueues
ASP: NServiceBus.Persistence.AzureStorage
ASTP: NServiceBus.Persistence.AzureTable
Aspire: Particular.Aspire.Hosting.ServicePlatform
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have a client package down the track (which seems to be a valid assumption to make), should we name this so that's more explicit and allows for other packages? So perhaps:

Suggested change
Aspire: Particular.Aspire.Hosting.ServicePlatform
AspirePlatformHost: Particular.Aspire.Hosting.ServicePlatform

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this
I think I made it Aspire.Hostingin my first pass

Comment thread platform/aspire/index.md Outdated
Comment thread platform/aspire/index.md

See [Usage reporting when using the Azure Service Bus transport](/servicecontrol/servicecontrol-instances/configuration.md#usage-reporting-when-using-the-azure-service-bus-transport) for what each value is used for in ServiceControl.

#### Options
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth listing this here if these are the same as linked to above? Otherwise if those defaults\requirements change then we'll have to repeat the same here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its worth keeping. These document the API specifically. If these changed on the transport, we'd need to change it in the package API anyway. The table also gives a bit more info on the type of param for the API.

Comment thread platform/aspire/index.md

#### Options

| Option | Default |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth listing this here if these are the same as linked to above? Otherwise if those defaults\requirements change then we'll have to repeat the same here.

Comment thread platform/aspire/index.md
// });
```

Refer to the following table for the default endpoint names and ports exposed by each component:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, if we mention this info already elsewhere, should we just point to it instead of repeating it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the endpoint name info isn't documented elsewhere. I think you need this info for WithEndpoint(endpointName, callback), and those names are internal const in the package

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, maybe we need to make those consts public?

Comment thread platform/aspire/index.md
Two integration-specific points to keep in mind for any publish target:

- The license parameter default is materialized into the manifest at publish time. Supply the license through Aspire parameter inputs in production so the value does not live in the published output. See [Supplying the license in production](#production-considerations-supplying-the-license-in-production).
- The Learning transport is blocked in publish mode unless explicitly opted in. See [Learning transport in publish mode](#production-considerations-learning-transport-in-publish-mode).
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refers to a section that no longer exists

Suggested change
- The Learning transport is blocked in publish mode unless explicitly opted in. See [Learning transport in publish mode](#production-considerations-learning-transport-in-publish-mode).
- The Learning transport is blocked in publish mode.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbev rbev requested a review from warwickschroeder May 25, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants