Skip to content

Hide some aspects when using embedded mode #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
johnsimons wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Hide some aspects when using embedded mode #2761

johnsimons wants to merge 1 commit into from

Conversation

@johnsimons
Copy link
Member

@johnsimons johnsimons commented Dec 12, 2025 •
edited by mikeminutillo
Loading

Updated the UI to remove the need to show versions for ServiceControl and ServicePulse, when ServicePulse and ServiceControl are shipped together, so really a single version

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

mikeminutillo
mikeminutillo approved these changes Dec 15, 2025
View reviewed changes
src/Frontend/src/components/PageFooter.vue
>(<FAIcon class="footer-icon fake-link" :icon="faArrowTurnUp" /> <a :href="newVersions.newSCVersion.newscversionlink" target="_blank">v{{ newVersions.newSCVersion.newscversionnumber }} available</a>)</span
>
<template v-if="!isEmbedded">
<span v-if="!newVersions.newSPVersion.newspversion && environment.sp_version"> ServicePulse v{{ environment.sp_version }} </span>
Copy link
Member

@mikeminutillo mikeminutillo Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If may still be worthwhile to show the ServicePulse version, just not the version check.

Copy link
Member Author

@johnsimons johnsimons Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this is something we need to think about it, at the moment the versions are the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeminutillo mikeminutillo mikeminutillo approved these changes

@PhilBastian PhilBastian Awaiting requested review from PhilBastian

Assignees

@johnsimons johnsimons

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnsimons @mikeminutillo