Fix RavenDB Management Studio link binding issue #5242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RavenDB Management Studio link binding issue
Summary
This PR fixes a property name mismatch introduced in PR #5237 that caused the RavenDB Management Studio hyperlink to be grayed out and non-functional in the ServiceControl Management UI.
Problem
After merging PR #5237 "Point RavenDB Management Studio link to localhost", the RavenDB Management Studio link in the Advanced Options maintenance mode section became unresponsive. The link appeared grayed out and clicking it had no effect.
Root Cause
PR #5237 renamed the property from
StorageUrltoRavenDbStudioUrlinServiceControlBaseService.cs, but the corresponding ViewModel property inServiceControlAdvancedViewModel.cswas incorrectly namedRavenStudioUrl(missing "Db"). This property name mismatch caused the WPF data binding to fail.Solution
ServiceControlAdvancedViewModel.csfromRavenStudioUrltoRavenDbStudioUrlFiles Changed
src/ServiceControl.Config/UI/AdvancedOptions/ServiceControlAdvancedViewModel.csTesting
http://localhost:{port}/studio/index.html#databasesFixes issue introduced in #5237