Skip to content

Fix API approval test: IEvent inherits from IMessage#455

Draft
Copilot wants to merge 5 commits intomasterfrom
copilot/fix-5038441-24321688-13be2a2e-56b5-4d72-b694-29a87c8aa042
Draft

Fix API approval test: IEvent inherits from IMessage#455
Copilot wants to merge 5 commits intomasterfrom
copilot/fix-5038441-24321688-13be2a2e-56b5-4d72-b694-29a87c8aa042

Conversation

Copy link

Copilot AI commented Feb 26, 2026

API approval test fails because NServiceBus.IEvent inherits from NServiceBus.IMessage. PublicApiGenerator correctly emits both interfaces, but the approved baseline only listed IEvent.

Changes

  • Updated APIApprovals.PublicClr.approved.txt to include both IEvent and IMessage for all 10 contract classes

The generated API signature is:

public class CustomCheckFailed : NServiceBus.IEvent, NServiceBus.IMessage

This matches how C# represents interface inheritance in reflection/metadata - derived interfaces are explicitly listed alongside their base interfaces in the public API surface.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • f.feedz.io
    • Triggering command: /usr/bin/dotnet dotnet test --no-build --verbosity normal (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build ServiceControl.Contracts.sln --configuration Release (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits February 26, 2026 11:15
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Copilot AI changed the title Add IEvent interface to ServiceControl.Contracts message classes Fix API approval test: IEvent inherits from IMessage Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants