Fix API approval test: IEvent inherits from IMessage#455
Draft
Fix API approval test: IEvent inherits from IMessage#455
Conversation
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Copilot stopped work on behalf of
danielmarbach due to an error
February 26, 2026 11:20
Copilot
AI
changed the title
[WIP] Copilot Request
Add IEvent interface to ServiceControl.Contracts message classes
Feb 26, 2026
Copilot
AI
changed the title
Add IEvent interface to ServiceControl.Contracts message classes
Fix API approval test: IEvent inherits from IMessage
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API approval test fails because
NServiceBus.IEventinherits fromNServiceBus.IMessage. PublicApiGenerator correctly emits both interfaces, but the approved baseline only listedIEvent.Changes
APIApprovals.PublicClr.approved.txtto include bothIEventandIMessagefor all 10 contract classesThe generated API signature is:
This matches how C# represents interface inheritance in reflection/metadata - derived interfaces are explicitly listed alongside their base interfaces in the public API surface.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.feedz.io/usr/bin/dotnet dotnet test --no-build --verbosity normal(dns block)/usr/bin/dotnet dotnet build ServiceControl.Contracts.sln --configuration Release(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.