Add support in convert.nemo_to_sgrid for depthw coordinate#2626
Merged
VeckoTheGecko merged 6 commits intoParcels-code:mainfrom May 6, 2026
Merged
Add support in convert.nemo_to_sgrid for depthw coordinate#2626VeckoTheGecko merged 6 commits intoParcels-code:mainfrom
convert.nemo_to_sgrid for depthw coordinate#2626VeckoTheGecko merged 6 commits intoParcels-code:mainfrom
Conversation
VeckoTheGecko
commented
May 4, 2026
| _NEMO_EXPECTED_COORDS = [ | ||
| "glamf", | ||
| "gphif", | ||
| ] # "depthw" # TODO: Depthw needs to be available if the data has a depth dim. Refactor the whole convert module, this can surely all be handled better. |
Contributor
Author
There was a problem hiding this comment.
Note
Refactor the whole convert module, this can surely all be handled better.
Is still on my TODO list (though quite low down). I have ideas on how we can make the conversion very robust but I want that to come later.
Also make depthw an optional coord for NEMO
Contributor
Author
I just did, and I think its working - though didn't have the time to wait for the run to complete. I think that's the last of the bughunting - working on perf on Wed |
erikvansebille
approved these changes
May 6, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good to me. Just one small question below. So the benchmarks run with this PR?
Contributor
Author
Just spent today getting Lorenz setup with a workspace to run the benchmarks. Unfortunately the benchmarks don't pass - getting the following error: As the error message is different, I think this is orthogonal |
VeckoTheGecko
force-pushed
the
push-rttuqnslyyqu
branch
from
e6aa98e to
c107e12
Compare
Contributor
Author
|
@erikvansebille how should we proceed with #2626 (comment) ? Do you want to continue looking into it? I don't think it is a blocker for me at the moment, though we will need a running benchmark suite in the next couple weeks sometime |
Member
|
Hmm, annoying that these benchmark runs continue to fail. I'm having trouble reproducing these runs, as my laptop crashes on the large benchmarks Perhaps we need to start with smaller/simpler benchmarks? Can you work on performance with a relatively simple script first? For example the script we use in the Argo tutorial at https://docs.oceanparcels.org/en/main/user_guide/examples/tutorial_Argofloats.html? And then with an without the explicit |
Contributor
Author
|
At the moment I want to work with a stripped down version of Parcels to see how we can best interface with the internals of Xarray - then use that to inform the rest of the work. We can also work with simpler examples (e.g., items from the test suite or the Argo tutorial) but I think for the moment working with a stripped down version would be more informative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to getting the benchmark suite running (including the prior PR - #2605 ) this PR does the following:
test_convert.py::test_nemo_to_sgrid_with_depthtest_nemo_to_sgrid_with_depth)convertmodule to allow for thedepthwdimension to be optionally providedconvertmodule allowing for easier refactoring/overviewStill need to double check that this fixes all the problems in the benchmark repo - will do that on Wednesday. If you could review the code in the meantime that would be great @erikvansebille :)
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None used