-
Notifications
You must be signed in to change notification settings - Fork 168
How to guide dt and integration scheme #2438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
erikvansebille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great notebook! A few suggestions below
| <!-- examples/tutorial_kernelloop.ipynb --> | ||
|
|
||
| ```{toctree} | ||
| :caption: Run a simulation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other sections start with a How-to guide (with a book emoji), this one doesn't. Is that a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s not a problem; explanations (with the book emoji) should only exist for more complicated components that benefit from background reading. For “Create ParticleSets” and “Run a simulation” I think the “Parcels conceptual workflow” is a sufficient explanation.
for more information, see https://pre-commit.ci
This PR adds a guide describing how to choose an appropriate dt and integration scheme. It is based on @michaeldenes notebook from the 10-years Parcels event.
The basics of how to write a custom kernel are now in the Parcels conceptual workflow explanation, and I have added a bit more text and figures to help users decide what to consider in their simulation setup. @michaeldenes I am mainly interested in your thoughts on how detailed this should be and how to generalize the advice we can give in this guide. Curious to hear what you think!