Skip to content

ty mojang #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Diamondback88 merged 2 commits into from
Dec 20, 2024
Merged

ty mojang #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
977168f
ty mojang
Diamondback88 Dec 20, 2024
26c7137
Merge branch 'staging' into point-system
Diamondback88 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions modules/src/main/java/parallelmc/parallelutils/modules/points/events/OnAdvancementDone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import parallelmc.parallelutils.modules.parallelchat.ParallelChat;
import parallelmc.parallelutils.modules.points.Points;

import java.util.Objects;
import java.util.logging.Level;

public class OnAdvancementDone implements Listener {
Expand All @@ -21,8 +22,9 @@ public void onAdvancementDone(PlayerAdvancementDoneEvent event) {
if (points == -1) {
// If the advancement is a root advancement or recipes advancement, don't print an error message.
// We can assume that advancements without displays are recipe advancements
// ParallelUtils.log(Level.WARNING, advancementTitle.toString());
if (advancement.getRoot() != advancement && advancement.getDisplay() != null) {
// Idk why I have to check that the displays are equal and not the advancement objects themselves, ty mojang
if (!(Objects.equals(advancement.getRoot().getDisplay(), advancement.getDisplay()))
&& advancement.getDisplay() != null) {
ParallelUtils.log(Level.WARNING, "Advancement " + advancement.getKey().asString() + " has no associated point value! Skipping...");
}
return;
Expand Down
Loading