Skip to content

Fix/furnace itemstack #13569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itshaithamn wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −10
Open

Fix/furnace itemstack #13569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24d3bba
Adjusting FurnceExtractEvent call from Material to ItemStack reference
itshaithamn Jan 19, 2026
24892a8
Adjusting FurnceExtractEvent call from Material to ItemStack referenc…
itshaithamn Jan 19, 2026
d2b05c2
Adding an itemStack getter method to FurnaceExtractEvent
itshaithamn Jan 19, 2026
2aab703
added @NotNull tag
itshaithamn Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions paper-api/src/main/java/org/bukkit/event/inventory/FurnaceExtractEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
package org.bukkit.event.inventory;

import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.block.BlockExpEvent;
import org.bukkit.material.MaterialData;
import org.bukkit.inventory.ItemStack;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;

Expand All @@ -17,17 +16,14 @@
public class FurnaceExtractEvent extends BlockExpEvent {

private final Player player;
private final Material itemType;
private final ItemStack itemStack;
private final int itemAmount;

@ApiStatus.Internal
public FurnaceExtractEvent(@NotNull Player player, @NotNull Block block, @NotNull Material itemType, int itemAmount, int exp) {
public FurnaceExtractEvent(@NotNull Player player, @NotNull Block block, @NotNull ItemStack itemStack, int itemAmount, int exp) {
super(block, exp);
this.player = player;
if (itemType != null && itemType.isLegacy()) {
itemType = Bukkit.getUnsafe().fromLegacy(new MaterialData(itemType), true);
}
this.itemType = itemType;
this.itemStack = itemStack;
this.itemAmount = itemAmount;
}

Expand All @@ -48,7 +44,17 @@ public Player getPlayer() {
*/
@NotNull
public Material getItemType() {
return this.itemType;
return this.itemStack.getType();
}

/**
* Get the ItemStack of the item triggering the event
*
* @return the item stack
*/
@NotNull
public ItemStack getItemStack(){
return this.itemStack;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...ches/sources/net/minecraft/world/level/block/entity/AbstractFurnaceBlockEntity.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@
+ event = new org.bukkit.event.inventory.FurnaceExtractEvent(
+ serverPlayer.getBukkitEntity(),
+ org.bukkit.craftbukkit.block.CraftBlock.at(level, blockPos),
+ org.bukkit.craftbukkit.inventory.CraftItemType.minecraftToBukkit(itemStack.getItem()),
+ itemStack.asBukkitCopy(),
+ amount,
+ floor
+ );
Expand Down