Skip to content

Fix Mob#isInDaylight not being accurate #13499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Warriorrrr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Mob#isInDaylight not being accurate #13499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1285e59
Fix Mob#isInDaylight not being accurate
Warriorrrr Jan 4, 2026
e63b20c
Merge branch 'main' into fix/mob-isindaylight
Warriorrrr Jan 4, 2026
a03b120
Add new bool param
Warriorrrr Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions paper-server/patches/sources/net/minecraft/world/entity/Mob.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,25 @@
this.pickUpItem(serverLevel, itemEntity);
}
}
@@ -488,12 +_,17 @@
}

public boolean isSunBurnTick() {
+ // Paper start - Add boolean parameter to skip random for isInDaylight
+ return isSunBurnTick(false);
+ }
+ public boolean isSunBurnTick(boolean skipRandom) {
+ // Paper end - Add boolean parameter to skip random for isInDaylight
if (!this.level().isClientSide() && this.level().environmentAttributes().getValue(EnvironmentAttributes.MONSTERS_BURN, this.position())) {
float lightLevelDependentMagicValue = this.getLightLevelDependentMagicValue();
BlockPos blockPos = BlockPos.containing(this.getX(), this.getEyeY(), this.getZ());
boolean flag = this.isInWaterOrRain() || this.isInPowderSnow || this.wasInPowderSnow;
if (lightLevelDependentMagicValue > 0.5F
- && this.random.nextFloat() * 30.0F < (lightLevelDependentMagicValue - 0.4F) * 2.0F
+ && (skipRandom || this.random.nextFloat() * 30.0F < (lightLevelDependentMagicValue - 0.4F) * 2.0F) // Paper - Add boolean parameter to skip random for isInDaylight
&& !flag
&& this.level().canSeeSky(blockPos)) {
return true;
@@ -509,18 +_,24 @@

protected void pickUpItem(ServerLevel level, ItemEntity entity) {
Expand Down
3 changes: 2 additions & 1 deletion paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftMob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.google.common.base.Preconditions;
import java.util.Optional;
import net.kyori.adventure.util.TriState;
import net.minecraft.core.BlockPos;
import net.minecraft.sounds.SoundEvent;
import org.bukkit.Sound;
import org.bukkit.craftbukkit.CraftLootTable;
Expand Down Expand Up @@ -110,7 +111,7 @@ public long getSeed() {

@Override
public boolean isInDaylight() {
return getHandle().isSunBurnTick();
return this.getHandle().isSunBurnTick(true);
}

@Override
Expand Down
Loading