success criterias for audience test #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/testaudience.js
Outdated
| * @fileoverview Defines tests for audience engagement. | ||
| * | ||
| * Success criterias: | ||
| * - each element from (nodes) array should exist; |
Member
There was a problem hiding this comment.
added 2 commits
June 30, 2016 13:42
tests/testaudience.js
Outdated
|
|
||
| if (!content || !(PATTERN.test(content) || 'N/A' == content)) { | ||
| return true; | ||
| if (!content || !PATTERN.test(content) || content == 'N/A') { |
Member
There was a problem hiding this comment.
RomanFedytskyi
assigned
ppokyd and unassigned
Alexsv7,
vasylsemiliak,
AlbaMontis,
zalesky and
mshchygol
added 3 commits
July 11, 2016 13:44
|
LGTM |
1 similar comment
Contributor
|
LGTM |
tests/testaudience.js
Outdated
| * - Elements with ID prefix 'audience-engagement-‘ should contain content and | ||
| * the format should adhere to the following examples: 10.1% or 10% or | ||
| * 10:1 or 10; | ||
| * - Content of elements with ID prefix 'audience-engagement-‘ can't |
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.