Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions fastdeploy/entrypoints/chat_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,10 @@ def parse_chat_messages(messages: List[ChatCompletionMessageParam]):
role = message["role"]
content = message["content"]

parsed_content = []
if content is None:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 建议 content 类型从固定 list 改为 str | None | list,是接口行为变更。

原实现保证 parsed_content 始终为 list(包括空列表和 [{"type":"text",...}]),下游所有消费方(如 Processor.process_messages)可安全迭代。改动后 content=None 时返回 Nonecontent=str 时返回裸字符串,若下游存在 for part in content: 等迭代逻辑则会引发 TypeError(None 不可迭代)或错误地逐字符迭代字符串。

请确认 parse_chat_messages 所有消费方(Processor.process_messages 等)均已更新,能正确处理 Nonestr 类型。

parsed_content = []
parsed_content = content
elif isinstance(content, str):
parsed_content = [{"type": "text", "text": content}]
parsed_content = content

This comment was marked as outdated.

else:

This comment was marked as outdated.

parsed_content = [parse_content_part(mm_parser, part) for part in content]

Expand Down
9 changes: 7 additions & 2 deletions fastdeploy/entrypoints/llm.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def chat(
raise RuntimeError(f"Failed to validate 'tools' parameter in chat method: {e}") from e

req_ids = self._add_request(
prompts=[{"messages": msg} for msg in messages],
prompts=messages,
sampling_params=sampling_params,
chat_template_kwargs=chat_template_kwargs,
chat_template=chat_template,
Expand Down Expand Up @@ -326,11 +326,16 @@ def _add_request(
"prompt": prompts[i],
"request_id": request_id,
}
elif isinstance(prompts[i], list) and isinstance(prompts[i][0], int):
elif isinstance(prompts[i], list) and len(prompts[i]) > 0 and isinstance(prompts[i][0], int):
tasks = {
"prompt_token_ids": prompts[i],
"request_id": request_id,
}
elif isinstance(prompts[i], list) and len(prompts[i]) > 0 and isinstance(prompts[i][0], dict):

This comment was marked as outdated.

tasks = {
"messages": prompts[i],
"request_id": request_id,
}
elif isinstance(prompts[i], dict):
tasks = prompts[i]
tasks["request_id"] = request_id
Expand Down
29 changes: 29 additions & 0 deletions fastdeploy/input/multimodal/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Multimodal processors for FastDeploy."""

from fastdeploy.input.multimodal.ernie_vl import ErnieVLProcessor
from fastdeploy.input.multimodal.mm_processor import MMProcessor
from fastdeploy.input.multimodal.paddleocr_vl import PaddleOCRVLProcessor
from fastdeploy.input.multimodal.qwen3_vl import Qwen3VLProcessor
from fastdeploy.input.multimodal.qwen_vl import QwenVLProcessor

__all__ = [
"MMProcessor",
"QwenVLProcessor",
"Qwen3VLProcessor",
"ErnieVLProcessor",
"PaddleOCRVLProcessor",
]
147 changes: 147 additions & 0 deletions fastdeploy/input/multimodal/common.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
# Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""Shared image utility functions for all VL image processors."""

import math

import numpy as np

from fastdeploy.utils import data_processor_logger

__all__ = [
"round_by_factor",
"ceil_by_factor",
"floor_by_factor",
"is_scaled_image",
"smart_resize",
"smart_resize_qwen",
"smart_resize_paddleocr",
]


def round_by_factor(number: int, factor: int) -> int:
"""Returns the closest integer to 'number' that is divisible by 'factor'."""
return round(number / factor) * factor


def ceil_by_factor(number: int, factor: int) -> int:
"""Returns the smallest integer >= 'number' that is divisible by 'factor'."""
return math.ceil(number / factor) * factor


def floor_by_factor(number: int, factor: int) -> int:
"""Returns the largest integer <= 'number' that is divisible by 'factor'."""
return math.floor(number / factor) * factor


def is_scaled_image(image: np.ndarray) -> bool:
"""Check if image pixel values are already normalized to [0, 1] range."""
if image.dtype == np.uint8:
return False
return np.min(image) >= 0 and np.max(image) <= 1


def smart_resize_qwen(
height: int,
width: int,
factor: int,
min_pixels: int,
max_pixels: int,
max_ratio: int = 200,
) -> tuple:
"""Smart image resizing for ERNIE / Qwen2.5 / Qwen3 models."""
if max(height, width) / min(height, width) > max_ratio:
if height > width:
new_width = max(factor, round_by_factor(width, factor))
new_height = floor_by_factor(new_width * max_ratio, factor)
else:
new_height = max(factor, round_by_factor(height, factor))
new_width = floor_by_factor(new_height * max_ratio, factor)

data_processor_logger.info(
f"absolute aspect ratio must be smaller than {max_ratio}, "
f"got {max(height, width) / min(height, width)}, "
f"resize to {max(new_height, new_width) / min(new_height, new_width)}"
)
height = new_height
width = new_width

h_bar = max(factor, round_by_factor(height, factor))
w_bar = max(factor, round_by_factor(width, factor))
if h_bar * w_bar > max_pixels:
beta = math.sqrt((height * width) / max_pixels)
h_bar = floor_by_factor(height / beta, factor)
w_bar = floor_by_factor(width / beta, factor)
elif h_bar * w_bar < min_pixels:
beta = math.sqrt(min_pixels / (height * width))
h_bar = ceil_by_factor(height * beta, factor)
w_bar = ceil_by_factor(width * beta, factor)

if min_pixels > h_bar * w_bar or h_bar * w_bar > max_pixels:
raise ValueError(f"encounter invalid h_bar: {h_bar}, w_bar: {w_bar}")

return h_bar, w_bar


def smart_resize_paddleocr(
height: int,
width: int,
factor: int = 28,
min_pixels: int = 28 * 28 * 130,
max_pixels: int = 28 * 28 * 1280,
) -> tuple:
"""Smart image resizing for PaddleOCR-VL model."""
if height < factor:
data_processor_logger.debug(f"smart_resize_paddleocr: height={height} < factor={factor}, reset height=factor")
width = round((width * factor) / height)
height = factor

if width < factor:
data_processor_logger.debug(f"smart_resize_paddleocr: width={width} < factor={factor}, reset width=factor")
height = round((height * factor) / width)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 建议 smart_resize_paddleocr 缺少最终像素数校验。

smart_resize_qwen 在返回前有:

if min_pixels > h_bar * w_bar or h_bar * w_bar > max_pixels:
    raise ValueError(f"encounter invalid h_bar: {h_bar}, w_bar: {w_bar}")

smart_resize_paddleocr 没有等价检查,极端输入下可能产生超出 [min_pixels, max_pixels] 范围的结果并静默通过,建议补齐。

width = factor

if max(height, width) / min(height, width) > 200:
raise ValueError(
f"absolute aspect ratio must be smaller than 200, " f"got {max(height, width) / min(height, width)}"
)

h_bar = round(height / factor) * factor
w_bar = round(width / factor) * factor
if h_bar * w_bar > max_pixels:
beta = math.sqrt((height * width) / max_pixels)

This comment was marked as outdated.

h_bar = math.floor(height / beta / factor) * factor
w_bar = math.floor(width / beta / factor) * factor
elif h_bar * w_bar < min_pixels:
beta = math.sqrt(min_pixels / (height * width))
h_bar = math.ceil(height * beta / factor) * factor
w_bar = math.ceil(width * beta / factor) * factor

return h_bar, w_bar


def smart_resize(
height: int,
width: int,
factor: int,
min_pixels: int,
max_pixels: int,
max_ratio: int = 200,
variant: str = "qwen",
) -> tuple:
"""Unified smart_resize dispatcher."""
if variant == "paddleocr":
return smart_resize_paddleocr(height, width, factor, min_pixels, max_pixels)
return smart_resize_qwen(height, width, factor, min_pixels, max_pixels, max_ratio)
Loading
Loading