[Optimization][DataProcessor] Refactor duplicated validation logic in VL processors and serving classes#6380
Draft
[Optimization][DataProcessor] Refactor duplicated validation logic in VL processors and serving classes#6380
Conversation
|
|
…ts utility Co-authored-by: Jiang-Jia-Jun <163579578+Jiang-Jia-Jun@users.noreply.github.com>
…etion Co-authored-by: Jiang-Jia-Jun <163579578+Jiang-Jia-Jun@users.noreply.github.com>
…ove docstring Co-authored-by: Jiang-Jia-Jun <163579578+Jiang-Jia-Jun@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code for improved maintainability
[Optimization][DataProcessor] Refactor duplicated validation logic in VL processors and serving classes
Feb 6, 2026
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Consolidate ~200 lines of duplicated validation logic across 8 VL processor implementations and multiple serving classes. Single point of maintenance for common validation patterns.
Modifications
Multimodal validation consolidation:
check_mm_limits()utility infastdeploy/input/utils.pyin(list membership) andeq(equality) type checking modesServing master check consolidation:
MasterCheckMixininfastdeploy/entrypoints/openai/utils.pyOpenAIServingChatandOpenAIServingCompletionserving_engineandserving_modelsunchanged (different implementation patterns)Impact:
Usage or Command
No API changes. Refactoring maintains existing behavior.
Accuracy Tests
Not applicable - pure refactoring with no functional changes.
Checklist
pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.