[Others] Exit to ensure no residual processes (cpu cache & dp)#6377
Open
CSWYF3634076 wants to merge 2 commits intoPaddlePaddle:developfrom
Open
[Others] Exit to ensure no residual processes (cpu cache & dp)#6377CSWYF3634076 wants to merge 2 commits intoPaddlePaddle:developfrom
CSWYF3634076 wants to merge 2 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6377 +/- ##
==========================================
Coverage ? 68.23%
==========================================
Files ? 391
Lines ? 52245
Branches ? 8145
==========================================
Hits ? 35647
Misses ? 13991
Partials ? 2607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| except Exception as e: | ||
| console_logger.error( | ||
| f"Error killing cache manager process {p.pid}: {e}, {str(traceback.format_exc())}" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
优雅退出,保证无残留进程 (启动服务具有CPU cache功能,ctrl+c关闭时会残留cache_transfer_manager进程)
Modifications
start_data_parallel_service在结束后调用expert_service._exit_sub_services()清理cache_transfer_manager进程
Usage or Command
main分支
启动后ctrl+c,有cache_transfer_manager.py的残留进程
PR
启动后ctrl+c,无残留进程
Accuracy Tests
no
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.