Skip to content

[BugFix] PD reorder fix and add ut#6375

Open
bukejiyu wants to merge 4 commits intoPaddlePaddle:developfrom
bukejiyu:e2e-ut
Open

[BugFix] PD reorder fix and add ut#6375
bukejiyu wants to merge 4 commits intoPaddlePaddle:developfrom
bukejiyu:e2e-ut

Conversation

@bukejiyu
Copy link
Collaborator

@bukejiyu bukejiyu commented Feb 5, 2026

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

1.PD重排修复异常hang问题
2.增加单测

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Feb 5, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@cae2709). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/worker/input_batch.py 36.84% 10 Missing and 2 partials ⚠️
fastdeploy/model_executor/pre_and_post_process.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6375   +/-   ##
==========================================
  Coverage           ?   68.33%           
==========================================
  Files              ?      391           
  Lines              ?    52172           
  Branches           ?     8129           
==========================================
  Hits               ?    35654           
  Misses             ?    13912           
  Partials           ?     2606           
Flag Coverage Δ
GPU 68.33% <40.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if self.attn_backends and getattr(self.attn_backends[0], "enable_ids_reorder", False):
if self.attn_backends and (
getattr(self.attn_backends[0], "enable_ids_reorder", False) or envs.ENABLE_PD_REORDER
):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为什么要另外增加一个开启方式呢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不然没法加单测,现在attn 默认不重排的,又没发直接给append attn开重排,就加了个环境变量

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants