fix: amm-1937 NumberFormatException in getExpiryReport API fixed #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



📋 Description
JIRA ID: AMM-1937
Root Cause:
A Strength field was added to the ExpiryReport model in PR #104, which changed the constructor signature from 7 parameters to 8 parameters:
New constructor signature :
ExpiryReport(facilityName, itemName, itemCategory, strength, batchNo, unitCostPrice, expiryDate, quantityInHand)
However, the SQL queries in ItemStockReportRepo.java for getExpiryReport() and getExpiryReportByFacilityID() were not updated to include the Strength column. This caused a parameter mismatch where:
Result: NumberFormatException: For input string: "2025-04-01"
Fix
Updated the SQL queries in ItemStockReportRepo.java to include the Strength column:
getExpiryReport() - Added Strength to SELECT clause
getExpiryReportByFacilityID() - Added Strength to SELECT clause
All queries now return 8 columns that correctly map to the updated ExpiryReport constructor parameters.
✅ Type of Change