Skip to content

Add leakage parameter for government infrastructure investment#1094

Open
MahadevBalla wants to merge 2 commits intoPSLmodels:masterfrom
MahadevBalla:feat/1086-gov-infra-leakage
Open

Add leakage parameter for government infrastructure investment#1094
MahadevBalla wants to merge 2 commits intoPSLmodels:masterfrom
MahadevBalla:feat/1086-gov-infra-leakage

Conversation

@MahadevBalla
Copy link
Copy Markdown

Closes #1086

Summary

  • Add new parameter infra_investment_leakage_rate to default_parameters.json
  • Apply leakage to public capital accumulation in fiscal.get_K_g()
  • Update the get_K_g() docstring to reflect the new law of motion
  • Add tests for the no-leakage baseline and a positive-leakage SS case

Testing

  • pytest tests/test_fiscal.py
  • pytest tests/test_fiscal.py -k "get_K_g"

Output / Validation

pytest tests/test_fiscal.py -k "get_K_g"
3 passed, 23 deselected in 4.38s

pytest tests/test_fiscal.py
26 passed in 8.77s

@jdebacker
Copy link
Copy Markdown
Member

@MahadevBalla Thanks for the PR!

I left one comment above. In addition, please run make format from the top level directory to format the .py files.

I would be good to update the theory docs in .docs/book/content/theory to reflect this new parameter. But we can do that in another PR if that's a problem.

I will try to complete and merge PR #1097 soon -- once those changes are in this branch, the test failures we're seeing here should be resolved.

@MahadevBalla MahadevBalla force-pushed the feat/1086-gov-infra-leakage branch from d9344ad to 8504836 Compare April 2, 2026 16:51
@MahadevBalla
Copy link
Copy Markdown
Author

Thanks for the review @jdebacker! I’ve made the phi_g change and run make format.
I won’t be able to work on the theory docs update until Sunday, but I can follow up with that separately after that.

@MahadevBalla MahadevBalla force-pushed the feat/1086-gov-infra-leakage branch from 8504836 to cee5502 Compare April 7, 2026 12:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.98%. Comparing base (bfe4c5b) to head (97018ce).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   72.98%   72.98%           
=======================================
  Files          21       21           
  Lines        5189     5190    +1     
=======================================
+ Hits         3787     3788    +1     
  Misses       1402     1402           
Flag Coverage Δ
unittests 72.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/fiscal.py 98.00% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a "leakage" parameter for gov't infrastructure spending

3 participants