Add leakage parameter for government infrastructure investment#1094
Add leakage parameter for government infrastructure investment#1094MahadevBalla wants to merge 2 commits intoPSLmodels:masterfrom
Conversation
|
@MahadevBalla Thanks for the PR! I left one comment above. In addition, please run I would be good to update the theory docs in I will try to complete and merge PR #1097 soon -- once those changes are in this branch, the test failures we're seeing here should be resolved. |
d9344ad to
8504836
Compare
|
Thanks for the review @jdebacker! I’ve made the |
8504836 to
cee5502
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 72.98% 72.98%
=======================================
Files 21 21
Lines 5189 5190 +1
=======================================
+ Hits 3787 3788 +1
Misses 1402 1402
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Closes #1086
Summary
infra_investment_leakage_ratetodefault_parameters.jsonfiscal.get_K_g()get_K_g()docstring to reflect the new law of motionTesting
pytest tests/test_fiscal.pypytest tests/test_fiscal.py -k "get_K_g"Output / Validation